Sign upLogin

ManageIQ/manageiq-smartstate

View on GitHub
Star
lib/metadata/util/win32/Win32Software.rb

Summary

Maintainability
B
6 hrs
Test Coverage
F
23%

Method postProcessApps has a Cognitive Complexity of 21 (exceeds 8 allowed). Consider refactoring.
Open

    def postProcessApps(appPath, fs)
      # The icon sections below will need to be uncommented when we are ready to start
      # implementing application image uploading.
      # iconNode = MIQRexml.findElement("Applications/images", xmlCol.root)
      appPath.each_element do |app|
Severity: Minor
Found in lib/metadata/util/win32/Win32Software.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Software has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Software
    attr_reader :applications, :patches, :product_keys

    PRODUCTS_MAPPING = [
      'DisplayName', :name,
Severity: Minor
Found in lib/metadata/util/win32/Win32Software.rb - About 2 hrs to fix

File Win32Software.rb has 254 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'manageiq/gems/pending'
require 'util/xml/xml_utils'
require 'util/miq-xml'
require 'metadata/util/win32/peheader'
Severity: Minor
Found in lib/metadata/util/win32/Win32Software.rb - About 2 hrs to fix

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

          rescue Exception # => err
Severity: Minor
Found in lib/metadata/util/win32/Win32Software.rb by rubocop

Checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

There are no issues that match your filters.

Category
Status