Method update_from_params has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring. Open
def update_from_params(params)
self.typ = params[:perf_typ] if params[:perf_typ]
self.days = params[:perf_days] if params[:perf_days]
self.rt_minutes = params[:perf_minutes].to_i if params[:perf_minutes]
self.hourly_date = params[:miq_date_1] if params[:miq_date_1] && typ == 'Hourly'- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method set_dates has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring. Open
def set_dates(start_date, end_date, allow_interval_override)
tz = time_profile_tz || self.tz # Use time profile tz or chosen tz, if no profile tz
self.sdate = start_date.in_time_zone(tz)
self.edate = end_date.in_time_zone(tz)
self.sdate_daily = sdate.hour.zero? ? sdate : sdate + 1.day- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity for set_dates is too high. [22/11] Open
def set_dates(start_date, end_date, allow_interval_override)
tz = time_profile_tz || self.tz # Use time profile tz or chosen tz, if no profile tz
self.sdate = start_date.in_time_zone(tz)
self.edate = end_date.in_time_zone(tz)
self.sdate_daily = sdate.hour.zero? ? sdate : sdate + 1.day- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6Cyclomatic complexity for update_from_params is too high. [17/11] Open
def update_from_params(params)
self.typ = params[:perf_typ] if params[:perf_typ]
self.days = params[:perf_days] if params[:perf_days]
self.rt_minutes = params[:perf_minutes].to_i if params[:perf_minutes]
self.hourly_date = params[:miq_date_1] if params[:miq_date_1] && typ == 'Hourly'- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6Cyclomatic complexity for cats is too high. [12/11] Open
def cats
return unless %w[EmsCluster Host Storage AvailabilityZone HostAggregate].include?(model)
self[:cats] ||=
begin- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6Method set_dates has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
def set_dates(start_date, end_date, allow_interval_override)
tz = time_profile_tz || self.tz # Use time profile tz or chosen tz, if no profile tz
self.sdate = start_date.in_time_zone(tz)
self.edate = end_date.in_time_zone(tz)
self.sdate_daily = sdate.hour.zero? ? sdate : sdate + 1.day- Create a ticketCreate a ticket
Consider simplifying this complex logical expression. Open
if hourly_date.present? &&
(hourly_date.to_date < sdate.to_date || hourly_date.to_date > edate.to_date || # it is out of range
(typ == 'Hourly' && time_profile && !time_profile_days.include?(hourly_date.to_date.wday))) # or out of profile
self.hourly_date = nil
end- Create a ticketCreate a ticket