Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/controllers/container_dashboard_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Class ContainerDashboardController has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class ContainerDashboardController < ApplicationController
  extend ActiveSupport::Concern

  include Mixins::GenericSessionMixin
  include Mixins::BreadcrumbsMixin
Severity: Minor
Found in app/controllers/container_dashboard_controller.rb - About 2 hrs to fix

Useless method definition detected.
Open

  def get_session_data
    super
  end
Severity: Minor
Found in app/controllers/container_dashboard_controller.rb by rubocop

Checks for useless method definitions, specifically: empty constructors and methods just delegating to super.

Safety:

This cop is unsafe as it can register false positives for cases when an empty constructor just overrides the parent constructor, which is bad anyway.

Example:

# bad
def initialize
  super
end

def method
  super
end

# good - with default arguments
def initialize(x = Object.new)
  super
end

# good
def initialize
  super
  initialize_internals
end

def method(*args)
  super(:extra_arg, *args)
end

There are no issues that match your filters.

Category
Status