Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/controllers/miq_ae_customization_controller/custom_buttons.rb

Summary

Maintainability
D
3 days
Test Coverage
F
40%

Method ab_get_node_info has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

  def ab_get_node_info(node)
    @nodetype = node.split("_")
    nodeid = node.split("-")

    # initializing variables to hold data for selected node
Severity: Minor
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for ab_get_node_info is too high. [43/11]
Open

  def ab_get_node_info(node)
    @nodetype = node.split("_")
    nodeid = node.split("-")

    # initializing variables to hold data for selected node
Severity: Minor
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method ab_get_node_info has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def ab_get_node_info(node)
    @nodetype = node.split("_")
    nodeid = node.split("-")

    # initializing variables to hold data for selected node
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 4 hrs to fix

Avoid deeply nested control flow statements.
Open

          @sb[:buttons].push(button) unless @sb[:buttons].include?(button)
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      if @custom_button.uri_attributes
        default_attributes = if @custom_button[:options].try(:[], :button_type)
                               %w[request service_template_name hosts]
                             else
                               %w[request]
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      button_order = @record[:set_data] && @record[:set_data][:button_order] ? @record[:set_data][:button_order] : nil
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      @sb[:dialog_label] = dialog_id ? Dialog.find(dialog_id).label : ""
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          next if bidx != b.id
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      @enablement_expression_table = exp_build_table(@custom_button.enablement_expression.exp) if @custom_button.enablement_expression.kind_of?(MiqExpression)
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

          next if b.custom_button_sets.present?
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      @visibility_expression_table = exp_build_table(@custom_button.visibility_expression.exp) if @custom_button.visibility_expression.kind_of?(MiqExpression)
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      @resolve[:new][:target_class] = if @nodetype[0].starts_with?("-ub-")
                                        # selected button is under unassigned folder
                                        @nodetype[0].sub('-ub-', '')
                                      else
                                        @nodetype[1]
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      if @custom_button.visibility && @custom_button.visibility[:roles] && @custom_button.visibility[:roles][0] != "_ALL_"
        MiqUserRole.all.sort_by(&:name).each do |r|
          @sb[:user_roles].push(r.name) if @custom_button.visibility[:roles].include?(r.name)
        end
      end
Severity: Major
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb - About 45 mins to fix

Avoid more than 3 levels of block nesting.
Open

            @resolve[:new][:attrs].push(attr) unless @resolve[:new][:attrs].include?(attr)
Severity: Minor
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb by rubocop

Checks for excessive nesting of conditional and looping constructs.

You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

The maximum level of nesting allowed is configurable.

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      button_order&.each do |bidx| # show assigned buttons in order they were saved
        @record.members.each do |b|
          next if bidx != b.id

          button = {:name         => b.name,
Severity: Minor
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb and 1 other location - About 50 mins to fix
app/controllers/application_controller/buttons.rb on lines 990..1001

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if @custom_button.visibility && @custom_button.visibility[:roles] && @custom_button.visibility[:roles][0] != "_ALL_"
        MiqUserRole.all.sort_by(&:name).each do |r|
          @sb[:user_roles].push(r.name) if @custom_button.visibility[:roles].include?(r.name)
        end
      end
Severity: Minor
Found in app/controllers/miq_ae_customization_controller/custom_buttons.rb and 1 other location - About 35 mins to fix
app/controllers/application_controller/buttons.rb on lines 1018..1022

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status