Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/controllers/ops_controller/settings/label_tag_mapping.rb

Summary

Maintainability
C
1 day
Test Coverage
B
81%

Method label_tag_mapping_edit has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def label_tag_mapping_edit
    assert_privileges("region_edit")

    case params[:button]
    when "cancel"
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for label_tag_mapping_edit is too high. [18/11]
Open

  def label_tag_mapping_edit
    assert_privileges("region_edit")

    case params[:button]
    when "cancel"
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method label_tag_mapping_edit has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def label_tag_mapping_edit
    assert_privileges("region_edit")

    case params[:button]
    when "cancel"
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 1 hr to fix

Method label_tag_mapping_update has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def label_tag_mapping_update(id, cat_description)
    assert_privileges("region_edit")
    mapping = ProviderTagMapping.find(id)
    begin
      if mapping.labeled_resource_type == ALL_ENTITIES
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 1 hr to fix

Method label_tag_mapping_delete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def label_tag_mapping_delete
    assert_privileges("region_edit")
    mapping = ProviderTagMapping.find(params[:id])
    category = mapping.tag.classification
    label_name = mapping.label_name
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 1 hr to fix

Method label_tag_mapping_delete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def label_tag_mapping_delete
    assert_privileges("region_edit")
    mapping = ProviderTagMapping.find(params[:id])
    category = mapping.tag.classification
    label_name = mapping.label_name
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_mapping has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_mapping(cat_description, entity, label_name)
    tag = classification_lookup_with_cache_by(cat_description)&.tag
    return :unique_mapping if tag && ProviderTagMapping.where(:label_name => label_name, :tag => tag).exists?

    if entity == ALL_ENTITIES
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method label_tag_mapping_update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def label_tag_mapping_update(id, cat_description)
    assert_privileges("region_edit")
    mapping = ProviderTagMapping.find(id)
    begin
      if mapping.labeled_resource_type == ALL_ENTITIES
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method label_tag_mapping_field_changed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def label_tag_mapping_field_changed
    assert_privileges("region_edit")

    return unless load_edit("label_tag_mapping_edit__#{params[:id]}", "replace_cell__explorer")
Severity: Minor
Found in app/controllers/ops_controller/settings/label_tag_mapping.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status