Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/controllers/storage_service_controller.rb

Summary

Maintainability
A
50 mins
Test Coverage

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  def edit
    params[:id] = checked_item_id if params[:id].blank?
    assert_privileges("storage_service_edit")
    @service = find_record_with_rbac(StorageService, params[:id])
    @in_a_form = true
Severity: Major
Found in app/controllers/storage_service_controller.rb and 6 other locations - About 25 mins to fix
app/controllers/cloud_network_controller.rb on lines 116..124
app/controllers/cloud_subnet_controller.rb on lines 81..89
app/controllers/cloud_volume_controller.rb on lines 168..176
app/controllers/host_initiator_group_controller.rb on lines 34..42
app/controllers/network_router_controller.rb on lines 52..61
app/controllers/physical_storage_controller.rb on lines 32..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  def new
    assert_privileges("storage_service_new")

    @in_a_form = true
    if params[:storage_manager_id]
Severity: Minor
Found in app/controllers/storage_service_controller.rb and 3 other locations - About 20 mins to fix
app/controllers/host_initiator_controller.rb on lines 19..27
app/controllers/host_initiator_group_controller.rb on lines 23..31
app/controllers/volume_mapping_controller.rb on lines 15..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status