Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/helpers/application_helper/button/old_dialogs_edit_delete.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use match? instead of =~ when MatchData is not used.
Open

      @error_message = if self[:id] =~ /_edit/
Severity: Minor
Found in app/helpers/application_helper/button/old_dialogs_edit_delete.rb by rubocop

In Ruby 2.4, String#match?, Regexp#match? and Symbol#match? have been added. The methods are faster than match. Because the methods avoid creating a MatchData object or saving backref. So, when MatchData is not used, use match? instead of match.

Example:

# bad
def foo
  if x =~ /re/
    do_something
  end
end

# bad
def foo
  if x.match(/re/)
    do_something
  end
end

# bad
def foo
  if /re/ === x
    do_something
  end
end

# good
def foo
  if x.match?(/re/)
    do_something
  end
end

# good
def foo
  if x =~ /re/
    do_something(Regexp.last_match)
  end
end

# good
def foo
  if x.match(/re/)
    do_something($~)
  end
end

# good
def foo
  if /re/ === x
    do_something($~)
  end
end

Use String#include? instead of a regex match with literal-only pattern.
Open

      @error_message = if self[:id] =~ /_edit/
Severity: Minor
Found in app/helpers/application_helper/button/old_dialogs_edit_delete.rb by rubocop

There are no issues that match your filters.

Category
Status