Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/helpers/application_helper/page_layouts.rb

Summary

Maintainability
C
1 day
Test Coverage
A
96%

Method show_adv_search? has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def show_adv_search?
    show_search = %w[
      auth_key_pair_cloud
      availability_zone
      automation_manager_configured_system
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb - About 2 hrs to fix

Method layout_uses_listnav? has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def layout_uses_listnav?
    return false if action_name == "show"
    return false if show_list_with_no_provider?

    return false if show_list_ansible?
Severity: Minor
Found in app/helpers/application_helper/page_layouts.rb - About 2 hrs to fix

Cyclomatic complexity for layout_uses_listnav? is too high. [12/11]
Open

  def layout_uses_listnav?
    return false if action_name == "show"
    return false if show_list_with_no_provider?

    return false if show_list_ansible?
Severity: Minor
Found in app/helpers/application_helper/page_layouts.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method layout_uses_listnav? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def layout_uses_listnav?
    return false if action_name == "show"
    return false if show_list_with_no_provider?

    return false if show_list_ansible?
Severity: Minor
Found in app/helpers/application_helper/page_layouts.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method layout_uses_tabs? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def layout_uses_tabs?
    return false if %w[login authenticate auth_error].include?(controller.action_name)

    layout = case @layout
             when 'container_dashboard', 'dashboard', 'ems_infra_dashboard', 'exception', 'physical_infra_overview'
Severity: Minor
Found in app/helpers/application_helper/page_layouts.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return false if controller.action_name.end_with?("tagging_edit")
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

    return false if controller.kind_of?(GenericObjectDefinitionController) && x_node != "root"
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

    return false if %w[
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

    return false if %w[
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

    return false if @layout.starts_with?("miq_request")
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

    return false if dashboard_no_listnav?
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    show_search = %w[
      auth_key_pair_cloud
      availability_zone
      automation_manager_configured_system
      cloud_database
Severity: Major
Found in app/helpers/application_helper/page_layouts.rb and 1 other location - About 1 hr to fix
app/controllers/mixins/sandbox.rb on lines 35..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status