Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/helpers/application_helper/toolbar_chooser.rb

Summary

Maintainability
F
1 wk
Test Coverage
D
69%

Method center_toolbar_filename_classic has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_classic
    # Original non vmx view code follows
    # toolbar buttons on sub-screens
    to_display = %w[availability_zones cloud_networks cloud_object_store_containers cloud_subnets configured_systems
                    cloud_tenants cloud_volumes cloud_volume_snapshots ems_clusters flavors floating_ips host_aggregates hosts host_initiators host_initiator_groups
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method center_toolbar_filename_classic has 116 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def center_toolbar_filename_classic
    # Original non vmx view code follows
    # toolbar buttons on sub-screens
    to_display = %w[availability_zones cloud_networks cloud_object_store_containers cloud_subnets configured_systems
                    cloud_tenants cloud_volumes cloud_volume_snapshots ems_clusters flavors floating_ips host_aggregates hosts host_initiators host_initiator_groups
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 4 hrs to fix

Cyclomatic complexity for center_toolbar_filename_classic is too high. [36/11]
Open

  def center_toolbar_filename_classic
    # Original non vmx view code follows
    # toolbar buttons on sub-screens
    to_display = %w[availability_zones cloud_networks cloud_object_store_containers cloud_subnets configured_systems
                    cloud_tenants cloud_volumes cloud_volume_snapshots ems_clusters flavors floating_ips host_aggregates hosts host_initiators host_initiator_groups
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

File toolbar_chooser.rb has 477 lines of code (exceeds 400 allowed). Consider refactoring.
Open

class ApplicationHelper::ToolbarChooser
  include RestfulControllerMixin

  # Return a blank tb if a placeholder is needed for AJAX explorer screens, return nil if no center toolbar to be shown
  def center_toolbar_filename
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 3 hrs to fix

Method center_toolbar_filename_ops has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_ops
    if x_active_tree == :settings_tree
      if x_node.split('-').last == "msc"
        return "miq_schedules_center_tb"
      elsif x_node.split('-').first == "msc"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method center_toolbar_filename_report has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_report
    if x_active_tree == :db_tree
      node = x_node
      if %w[root xx-g].include?(node)
        return nil
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for center_toolbar_filename_ops is too high. [23/11]
Open

  def center_toolbar_filename_ops
    if x_active_tree == :settings_tree
      if x_node.split('-').last == "msc"
        return "miq_schedules_center_tb"
      elsif x_node.split('-').first == "msc"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method center_toolbar_filename_services has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_services
    if x_active_tree == :sandt_tree
      if TreeBuilder.get_model_for_prefix(@nodetype) == "ServiceTemplate"
        "servicetemplate_center_tb"
      elsif @sb[:buttons_node]
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method center_toolbar_filename_automate_customization has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_automate_customization
    if x_active_tree == :old_dialogs_tree
      return @dialog ? "miq_dialog_center_tb" : "miq_dialogs_center_tb"
    elsif x_active_tree == :dialogs_tree
      if x_node == "root"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class ToolbarChooser has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationHelper::ToolbarChooser
  include RestfulControllerMixin

  # Return a blank tb if a placeholder is needed for AJAX explorer screens, return nil if no center toolbar to be shown
  def center_toolbar_filename
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 2 hrs to fix

Method center_toolbar_filename_pxe has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_pxe
    if x_active_tree == :pxe_servers_tree
      if x_node == "root"
        return "pxe_servers_center_tb"
      elsif x_node.split('-').first == "pi"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for center_toolbar_filename_automate_customization is too high. [17/11]
Open

  def center_toolbar_filename_automate_customization
    if x_active_tree == :old_dialogs_tree
      return @dialog ? "miq_dialog_center_tb" : "miq_dialogs_center_tb"
    elsif x_active_tree == :dialogs_tree
      if x_node == "root"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Cyclomatic complexity for center_toolbar_filename_report is too high. [15/11]
Open

  def center_toolbar_filename_report
    if x_active_tree == :db_tree
      node = x_node
      if %w[root xx-g].include?(node)
        return nil
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Cyclomatic complexity for center_toolbar_filename_explorer is too high. [14/11]
Open

  def center_toolbar_filename_explorer
    if %w[vm_cloud vm_infra vm_or_template].include?(@layout)
      center_toolbar_name_vm_or_template
    elsif x_active_tree == :ae_tree
      center_toolbar_filename_automate
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method center_toolbar_filename_explorer has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_explorer
    if %w[vm_cloud vm_infra vm_or_template].include?(@layout)
      center_toolbar_name_vm_or_template
    elsif x_active_tree == :ae_tree
      center_toolbar_filename_automate
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for view_toolbar_filename is too high. [13/11]
Open

  def view_toolbar_filename
    if render_download_view_tb?
      'download_view_tb'
    elsif @lastaction == "compare_miq" || @lastaction == "compare_compress"
      'compare_view_tb'
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Cyclomatic complexity for center_toolbar_name_vm_or_template is too high. [13/11]
Open

  def center_toolbar_name_vm_or_template
    if @record
      return "vm_performance_tb" if @display == "performance"

      case @record
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Cyclomatic complexity for center_toolbar_filename_services is too high. [12/11]
Open

  def center_toolbar_filename_services
    if x_active_tree == :sandt_tree
      if TreeBuilder.get_model_for_prefix(@nodetype) == "ServiceTemplate"
        "servicetemplate_center_tb"
      elsif @sb[:buttons_node]
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Cyclomatic complexity for center_toolbar_filename_pxe is too high. [12/11]
Open

  def center_toolbar_filename_pxe
    if x_active_tree == :pxe_servers_tree
      if x_node == "root"
        return "pxe_servers_center_tb"
      elsif x_node.split('-').first == "pi"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method center_toolbar_filename_ops has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def center_toolbar_filename_ops
    if x_active_tree == :settings_tree
      if x_node.split('-').last == "msc"
        return "miq_schedules_center_tb"
      elsif x_node.split('-').first == "msc"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 1 hr to fix

Method x_view_toolbar_filename has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def x_view_toolbar_filename
    if x_download_view_tb_render?
      'download_view_tb'
    elsif %w[miq_capacity_utilization].include?(@layout)
      'miq_capacity_view_tb'
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method center_toolbar_filename_pxe has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def center_toolbar_filename_pxe
    if x_active_tree == :pxe_servers_tree
      if x_node == "root"
        return "pxe_servers_center_tb"
      elsif x_node.split('-').first == "pi"
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 1 hr to fix

Method center_toolbar_filename_report has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def center_toolbar_filename_report
    if x_active_tree == :db_tree
      node = x_node
      if %w[root xx-g].include?(node)
        return nil
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 1 hr to fix

Method center_toolbar_filename_services has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def center_toolbar_filename_services
    if x_active_tree == :sandt_tree
      if TreeBuilder.get_model_for_prefix(@nodetype) == "ServiceTemplate"
        "servicetemplate_center_tb"
      elsif @sb[:buttons_node]
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 1 hr to fix

Method center_toolbar_name_vm_or_template has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_name_vm_or_template
    if @record
      return "vm_performance_tb" if @display == "performance"

      case @record
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method view_toolbar_filename has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def view_toolbar_filename
    if render_download_view_tb?
      'download_view_tb'
    elsif @lastaction == "compare_miq" || @lastaction == "compare_compress"
      'compare_view_tb'
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method center_toolbar_filename_storage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def center_toolbar_filename_storage
    if x_active_tree == :storage_tree
      if x_node_split.first == 'ds'
        return "storage_center_tb"
      else
Severity: Minor
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

      return x_node == "root" ? "miq_report_schedules_center_tb" : "miq_report_schedule_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

        if nodes.length == 2 && nodes[0] == "xx-ab"
          return "custom_button_set_center_tb"  # CI node is selected
        elsif (nodes.length == 1 && nodes[0].split('-').length == 3 && nodes[0].split('-')[1] == "ub") ||
              (nodes.length == 3 && nodes[0] == "xx-ab")
          return "custom_buttons_center_tb"     # group node is selected
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      elsif @layout == "configuration_profile"
        return "configuration_profile_center_tb"
      elsif @layout == "configuration" && @tabform == "ui_4"
        return "time_profiles_center_tb"
      elsif @layout == "diagnostics"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

    elsif x_active_tree == :widgets_tree
      node = x_node
      return node == "root" || node.split('-').length == 2 ? "miq_widgets_center_tb" : "miq_widget_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

      if x_node == "root"
        return "iso_datastores_center_tb"
      elsif x_node_split.first == "isi"
        # on image node
        return "iso_image_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

        return @lastaction == 'show_list' ? "#{@layout.pluralize}_center_tb" : "#{@layout}_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 45 mins to fix

Avoid too many return statements within this method.
Open

        return "zone_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "pxe_image_types_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "iso_image_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "tasks_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "diagnostics_zone_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "#{@layout}_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return @lastaction == 'show_list' ? 'miq_requests_center_tb' : 'miq_request_center_tb'
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "user_role_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "customization_templates_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "pxe_image_type_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return nil if @display == 'custom_button_events'
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return @lastaction == 'generic_object' ? nil : 'generic_objects_center'
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "time_profiles_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "zones_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "iso_datastores_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "#{@explorer ? "x_" : ""}vm_performance_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

          return "custom_buttons_center_tb"     # group node is selected
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "diagnostics_region_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "user_roles_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return node == "root" || node.split('-').length == 2 ? "miq_widgets_center_tb" : "miq_widget_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "#{@display}_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "user_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "tenants_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "tenant_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "saved_report_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "miq_reports_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "#{@display}_center"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return "drift_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return "dialog_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "miq_groups_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return "drifts_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "miq_group_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "iso_datastore_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "#{@display}_center"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return @lastaction == 'show_list' ? "#{@layout.pluralize}_center_tb" : "#{@layout}_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

          return "custom_button_center_tb"      # button node is selected
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "diagnostics_server_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "customization_template_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return "compare_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "diagnostics_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "users_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "miq_report_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "saved_report_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return nil if @in_a_form
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

      return x_node == "root" ? "miq_report_schedules_center_tb" : "miq_report_schedule_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "configuration_profile_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

Avoid too many return statements within this method.
Open

        return "logs_center_tb"
Severity: Major
Found in app/helpers/application_helper/toolbar_chooser.rb - About 30 mins to fix

There are no issues that match your filters.

Category
Status