Method at_tree_select_toggle
has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring. Open
def at_tree_select_toggle(type, edit_key)
automation_type = params[:automation_type] || default_entry_point_type
if edit_key
current_entry_point = @edit[:new][edit_key] # before updating @edit varibale.
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_automate_tree
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
def build_automate_tree(type)
tree_name = "#{type}_tree".to_sym
# build the ae tree to show the tree select box for entry point
if x_active_tree == tree_name && @edit && @edit[:new][:fqname]
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Cyclomatic complexity for at_tree_select_toggle is too high. [27/11] Open
def at_tree_select_toggle(type, edit_key)
automation_type = params[:automation_type] || default_entry_point_type
if edit_key
current_entry_point = @edit[:new][edit_key] # before updating @edit varibale.
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Method at_tree_select_toggle
has 88 lines of code (exceeds 25 allowed). Consider refactoring. Open
def at_tree_select_toggle(type, edit_key)
automation_type = params[:automation_type] || default_entry_point_type
if edit_key
current_entry_point = @edit[:new][edit_key] # before updating @edit varibale.
- Create a ticketCreate a ticket
Cyclomatic complexity for build_automate_tree is too high. [13/11] Open
def build_automate_tree(type)
tree_name = "#{type}_tree".to_sym
# build the ae tree to show the tree select box for entry point
if x_active_tree == tree_name && @edit && @edit[:new][:fqname]
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Method at_tree_select
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def at_tree_select(edit_key)
id = parse_nodetype_and_id(params[:id]).last
if params[:id].start_with?("aei-")
record = MiqAeInstance.find_by(:id => id)
@edit[:automate_tree_selected_path] = record.fqname
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method at_tree_select
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def at_tree_select(edit_key)
id = parse_nodetype_and_id(params[:id]).last
if params[:id].start_with?("aei-")
record = MiqAeInstance.find_by(:id => id)
@edit[:automate_tree_selected_path] = record.fqname
- Create a ticketCreate a ticket
Method build_automate_tree
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def build_automate_tree(type)
tree_name = "#{type}_tree".to_sym
# build the ae tree to show the tree select box for entry point
if x_active_tree == tree_name && @edit && @edit[:new][:fqname]
- Create a ticketCreate a ticket