Method ranges_and_rates has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def ranges_and_rates(num_tiers, tiers, detail, first_tier)
range_rate = {
:start => [first_tier.start ? first_tier.start : 0],
:finish => [first_tier.finish == Float::INFINITY ? _('Infinity') : first_tier.finish],
:fixed_rate => [first_tier.fixed_rate ? first_tier.fixed_rate : 0.0],- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method rate_summary has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def rate_summary(data, optional)
rows = []
data.to_a.sort_by { |rd| [rd.chargeable_field[:group].downcase, rd.chargeable_field[:description].downcase, rd[:sub_metric].to_s.downcase] }.each_with_index do |detail, detail_index|
cells = []
tiers = detail.chargeback_tiers.order(:start)- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method rate_summary has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def rate_summary(data, optional)
rows = []
data.to_a.sort_by { |rd| [rd.chargeable_field[:group].downcase, rd.chargeable_field[:description].downcase, rd[:sub_metric].to_s.downcase] }.each_with_index do |detail, detail_index|
cells = []
tiers = detail.chargeback_tiers.order(:start)- Create a ticketCreate a ticket
Useless assignment to variable - data. Open
data = []- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks for every useless assignment to local variable in every
scope.
The basic idea for this cop was from the warning of ruby -cw:
assigned but unused variable - fooCurrently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.
NOTE: Given the assignment foo = 1, bar = 2, removing unused variables
can lead to a syntax error, so this case is not autocorrected.
Safety:
This cop's autocorrection is unsafe because removing assignment from
operator assignment can cause NameError if this assignment has been used to declare
local variable. For example, replacing a ||= 1 to a || 1 may cause
"undefined local variable or method `a' for main:Object (NameError)".
Example:
# bad
def some_method
some_var = 1
do_something
endExample:
# good
def some_method
some_var = 1
do_something(some_var)
end