Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/helpers/miq_alert_helper.rb

Summary

Maintainability
C
1 day
Test Coverage
F
40%

Cyclomatic complexity for miq_summary_alert_parameters is too high. [25/11]
Open

  def miq_summary_alert_parameters(alert, expression_options, sb_data, perf_column_unit, ems)
    rows = []
    title = [_(MiqAlert.expression_types(alert.db)[alert.expression[:eval_method]]), _('Parameters')].join(' ')
    data = {:title => title, :mode => "miq_alert_parameters", :rows => []}
    ae_options = alert.expression[:options]
Severity: Minor
Found in app/helpers/miq_alert_helper.rb by rubocop

Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Method miq_summary_alert_parameters has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def miq_summary_alert_parameters(alert, expression_options, sb_data, perf_column_unit, ems)
    rows = []
    title = [_(MiqAlert.expression_types(alert.db)[alert.expression[:eval_method]]), _('Parameters')].join(' ')
    data = {:title => title, :mode => "miq_alert_parameters", :rows => []}
    ae_options = alert.expression[:options]
Severity: Major
Found in app/helpers/miq_alert_helper.rb - About 2 hrs to fix

Method miq_summary_alert_parameters has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def miq_summary_alert_parameters(alert, expression_options, sb_data, perf_column_unit, ems)
    rows = []
    title = [_(MiqAlert.expression_types(alert.db)[alert.expression[:eval_method]]), _('Parameters')].join(' ')
    data = {:title => title, :mode => "miq_alert_parameters", :rows => []}
    ae_options = alert.expression[:options]
Severity: Minor
Found in app/helpers/miq_alert_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method miq_summary_alert_info has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def miq_summary_alert_info(alert, event, sb_data)
    rows = []
    data = {:title => _('Info'), :mode => "miq_alert_info", :rows => []}
    rows.push({:cells => {:label => _("Description"), :value => alert.description}})
    rows.push({:cells => {:label => _("Active"), :value => alert.enabled ? _("Yes") : _("No")}})
Severity: Minor
Found in app/helpers/miq_alert_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method miq_summary_alert_send_email has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def miq_summary_alert_send_email(alert, email_to)
    alert_options = alert.options
    if alert_options && alert_options[:notifications] && alert.options[:notifications][:email].present?
      rows = []
      data = {:title => _('Send E-mail'), :mode => "miq_alert_send_email", :rows => []}
Severity: Minor
Found in app/helpers/miq_alert_helper.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method miq_summary_alert_parameters has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def miq_summary_alert_parameters(alert, expression_options, sb_data, perf_column_unit, ems)
Severity: Minor
Found in app/helpers/miq_alert_helper.rb - About 35 mins to fix

Method miq_summary_alert_send_sms has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def miq_summary_alert_send_sms(alert)
    alert_options = alert.options
    if alert_options && alert_options[:notifications] && alert_options[:notifications][:snmp].present?
      data = {:title => _('Send SNMP Trap'), :mode => "miq_alert_send_sms", :rows => []}
      rows = []
Severity: Minor
Found in app/helpers/miq_alert_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method miq_summary_alert_expression has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def miq_summary_alert_expression(expression_table)
    rows = []
    data = {:title => _('Expression'), :mode => "miq_alert_expression", :rows => []}
    if !expression_table.nil?
      expression_table.each do |token|
Severity: Minor
Found in app/helpers/miq_alert_helper.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
Open

        if ["AND", "OR", "(", ")"].exclude?([token].flatten.first)
Severity: Minor
Found in app/helpers/miq_alert_helper.rb by rubocop

There are no issues that match your filters.

Category
Status