Method settings_schedule_filter_details has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def settings_schedule_filter_details(schedule, exp_table)
data = {
:title => _('Filter'),
:mode => "settings_schedule_filter_details",
}- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Interpolation in single quoted string detected. Use double quoted strings if you need interpolation. Open
filter_data = search.search_type == "user" ? '_("My Filter: ") #{search.description}' : '_("Global Filter: ") #{search.description}'- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks for interpolation in a single quoted string.
Safety:
This cop's autocorrection is unsafe because although it always replaces single quotes as
if it were miswritten double quotes, it is not always the case. For example,
'#{foo} bar' would be replaced by "#{foo} bar", so the replaced code would evaluate
the expression foo.
Example:
# bad
foo = 'something with #{interpolation} inside'Example:
# good
foo = "something with #{interpolation} inside"Interpolation in single quoted string detected. Use double quoted strings if you need interpolation. Open
filter_data = search.search_type == "user" ? '_("My Filter: ") #{search.description}' : '_("Global Filter: ") #{search.description}'- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks for interpolation in a single quoted string.
Safety:
This cop's autocorrection is unsafe because although it always replaces single quotes as
if it were miswritten double quotes, it is not always the case. For example,
'#{foo} bar' would be replaced by "#{foo} bar", so the replaced code would evaluate
the expression foo.
Example:
# bad
foo = 'something with #{interpolation} inside'Example:
# good
foo = "something with #{interpolation} inside"