Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/javascript/components/cloud-network-form/cloud-network-form.jsx

Summary

Maintainability
A
2 hrs
Test Coverage

Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const validation = (values) => {
      const errors = {};
      if (values.ems_id === '-1') {
        errors.ems_id = __('Required');
Severity: Minor
Found in app/javascript/components/cloud-network-form/cloud-network-form.jsx - About 1 hr to fix

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    const validation = (values) => {
      const errors = {};
      if (values.ems_id === '-1') {
        errors.ems_id = __('Required');
      }
Severity: Major
Found in app/javascript/components/cloud-network-form/cloud-network-form.jsx and 7 other locations - About 55 mins to fix
app/javascript/components/cloud-object-store-container-form/index.jsx on lines 62..68
app/javascript/components/cloud-volume-form/index.jsx on lines 72..78
app/javascript/components/network-floatingIPs-form/index.jsx on lines 95..101
app/javascript/components/network-security-groups-form/index.jsx on lines 96..102
app/javascript/components/routers-form/index.jsx on lines 151..157
app/javascript/components/storage-service-form/index.jsx on lines 81..87
app/javascript/components/subnet-form/index.jsx on lines 82..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status