Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/javascript/components/embedded-terraform-repository-form/index.jsx

Summary

Maintainability
F
6 days
Test Coverage

Function EmbeddedTerraformRepositoryForm has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

const EmbeddedTerraformRepositoryForm = ({ repositoryId }) => {
  const [{
    initialValues, isLoading, provider,
  }, setState] = useState({
    isLoading: true,
Severity: Minor
Found in app/javascript/components/embedded-terraform-repository-form/index.jsx - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onSubmit has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const onSubmit = (values) => {
    const data = values;
    if (data.description === undefined) {
      data.description = '';
    }
Severity: Minor
Found in app/javascript/components/embedded-terraform-repository-form/index.jsx - About 1 hr to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

const EmbeddedTerraformRepositoryForm = ({ repositoryId }) => {
  const [{
    initialValues, isLoading, provider,
  }, setState] = useState({
    isLoading: true,
Severity: Major
Found in app/javascript/components/embedded-terraform-repository-form/index.jsx and 2 other locations - About 5 days to fix
app/javascript/components/ansible-repository-form/index.jsx on lines 9..116
app/javascript/components/workflow-repository-form/index.jsx on lines 9..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 947.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

carbon-components-react import should occur before import of @@ddf
Open

import { Loading } from 'carbon-components-react';
Severity: Minor
Found in app/javascript/components/embedded-terraform-repository-form/index.jsx by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status