Class TreeBuilder
has 28 methods (exceeds 20 allowed). Consider refactoring. Open
class TreeBuilder
include TreeKids
attr_reader :name, :options, :tree_nodes, :bs_tree
- Create a ticketCreate a ticket
Cyclomatic complexity for post_check is too high. [16/11] Open
def post_check(tree)
stack = tree.map(&:itself)
nodes = []
parents = []
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Method post_check
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def post_check(tree)
stack = tree.map(&:itself)
nodes = []
parents = []
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method post_check
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def post_check(tree)
stack = tree.map(&:itself)
nodes = []
parents = []
- Create a ticketCreate a ticket
Method count_only_or_objects_filtered
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def count_only_or_objects_filtered(count_only, objects, sort_by = nil, options = {}, &block)
- Create a ticketCreate a ticket
Method count_only_or_objects
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def count_only_or_objects(count_only, objects, sort_by = nil)
if count_only
objects.respond_to?(:order) ? objects.except(:order).size : objects.size
elsif sort_by.kind_of?(Proc)
objects.sort_by(&sort_by)
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method x_build_tree
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def x_build_tree
nodes = x_get_tree_objects(nil, false, []).map do |child|
# already a node? FIXME: make a class for node
if child.kind_of?(Hash) && child.key?(:text) && child.key?(:key) && child.key?(:image)
child
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Shadowing outer local variable - node
. Open
parent[:state][:checked] = parent[:nodes].map { |node| node.try(:[], :state).try(:[], :checked) }.reduce { |acc, curr| acc == curr ? acc : 'undefined' }
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks for the use of local variable names from an outer scope
in block arguments or block-local variables. This mirrors the warning
given by ruby -cw
prior to Ruby 2.6:
"shadowing outer local variable - foo".
NOTE: Shadowing of variables in block passed to Ractor.new
is allowed
because Ractor
should not access outer variables.
eg. following style is encouraged:
```ruby
worker_id, pipe = env
Ractor.new(worker_id, pipe) do |worker_id, pipe|
end
```
Example:
# bad
def some_method
foo = 1
2.times do |foo| # shadowing outer `foo`
do_something(foo)
end
end
Example:
# good
def some_method
foo = 1
2.times do |bar|
do_something(bar)
end
end