Sign upLogin

ManageIQ/manageiq-ui-classic

View on GitHub
Star
app/presenters/tree_builder_belongs_to_hac.rb

Summary

Maintainability
A
25 mins
Test Coverage
A
97%

Method x_get_tree_datacenter_kids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def x_get_tree_datacenter_kids(parent, count_only)
    children = parent.folders.each_with_object([]) do |child, arr|
      next unless child.kind_of?(EmsFolder)

      case child.name
Severity: Minor
Found in app/presenters/tree_builder_belongs_to_hac.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
Open

        [:folders_only, :clusters, :hosts].each { |m| arr.concat(child.send(m)) }
Severity: Minor
Found in app/presenters/tree_builder_belongs_to_hac.rb by rubocop

There are no issues that match your filters.

Category
Status