app/models/miq_report/formatters/csv.rb
Cyclomatic complexity for to_csv is too high. [13/11] Open
Open
def to_csv
return if (@sub_table || @table).nil?
csv_table = @sub_table ? @sub_table.dup : @table.dup # Duplicate table/sub_table since we will be deleting the ID column
csv_table.column_names.delete("id")
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant. Open
Open
key.data.except!(*(%w[id] + hidden_columns))
- Create a ticketCreate a ticket
- Exclude checks