Cyclomatic complexity for build_value_for_sort_suffix is too high. [24/11] Open
def build_value_for_sort_suffix(value, suffix)
value = value.in_time_zone(get_time_zone("UTC")) if value && value.kind_of?(Time)
value = value.to_time.utc.beginning_of_day if value && value.kind_of?(Date)
suffix = suffix.to_sym if suffix
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Cyclomatic complexity for build_sort_table is too high. [20/11] Open
def build_sort_table
return if sortby.nil? # Are there any sort fields
new_sortby = build_sort_suffix_data
sb_nil_sub = []
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
Checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.
def each_child_node(*types) # count begins: 1
unless block_given? # unless: +1
return to_enum(__method__, *types)
children.each do |child| # each{}: +1
next unless child.is_a?(Node) # unless: +1
yield child if types.empty? || # if: +1, ||: +1
types.include?(child.type)
end
self
end # total: 6
Method build_value_for_sort_suffix
has a Cognitive Complexity of 25 (exceeds 11 allowed). Consider refactoring. Open
def build_value_for_sort_suffix(value, suffix)
value = value.in_time_zone(get_time_zone("UTC")) if value && value.kind_of?(Time)
value = value.to_time.utc.beginning_of_day if value && value.kind_of?(Date)
suffix = suffix.to_sym if suffix
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_sort_table
has a Cognitive Complexity of 18 (exceeds 11 allowed). Consider refactoring. Open
def build_sort_table
return if sortby.nil? # Are there any sort fields
new_sortby = build_sort_suffix_data
sb_nil_sub = []
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_sort_suffix_data
has a Cognitive Complexity of 12 (exceeds 11 allowed). Consider refactoring. Open
def build_sort_suffix_data
new_sortby = []
rpt_sortby = Array.wrap(sortby)
rpt_sortby.each do |sb|
col, sfx = sb.split("__")
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Use filter_map
instead. Open
when :datetime then Time.at(@table.data.collect { |d| d.data[sb] }.compact.max.to_i + 1).utc
- Create a ticketCreate a ticket
- Exclude checks
Use filter_map
instead. Open
when :integer, :fixnum, :decimal, :float then @table.data.collect { |d| d.data[sb] }.compact.max.to_i + 1
- Create a ticketCreate a ticket
- Exclude checks
Use filter_map
instead. Open
when :date then @table.data.collect { |d| d.data[sb] }.compact.max.try(:+, 1)
- Create a ticketCreate a ticket
- Exclude checks