Sign upLogin

ManageIQ/miq_bot

View on GitHub
Star
app/models/batch_job.rb

Summary

Maintainability
A
45 mins
Test Coverage

Method check_complete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def check_complete
    # NOTE: The mutex may need to be upgraded to a database row lock
    #       if we go multi-process
    SEMAPHORE.synchronize do
      begin
Severity: Minor
Found in app/models/batch_job.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use Array.new(workers.size) with a block instead of .times.collect only if workers.size is always 0 or more.
Open

    new_entries = workers.size.times.collect { BatchEntry.new }
Severity: Minor
Found in app/models/batch_job.rb by rubocop

This cop checks for .times.map calls. In most cases such calls can be replaced with an explicit array creation.

Example:

# bad
9.times.map do |i|
  i.to_s
end

# good
Array.new(9) do |i|
  i.to_s
end

There are no issues that match your filters.

Category
Status