Sign upLogin

ManageIQ/miq_bot

View on GitHub
Star
lib/git_service/diff.rb

Summary

Maintainability
A
50 mins
Test Coverage

Method status_summary has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def status_summary
      changed, added, deleted = raw_diff.stat
      [
        changed.positive? ? "#{changed} #{"file".pluralize(changed)} changed" : nil,
        added.positive? ? "#{added} #{"insertion".pluralize(added)}(+)" : nil,
Severity: Minor
Found in lib/git_service/diff.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method file_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def file_status
      raw_diff.patches.each_with_object({}) do |patch, h|
        if new_file = patch.delta.new_file.try(:[], :path)
          additions = h.fetch_path(new_file, :additions) || 0
          h.store_path(new_file, :additions, (additions + patch.additions))
Severity: Minor
Found in lib/git_service/diff.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use filter_map instead.
Open

      raw_diff.deltas.collect { |delta| delta.try(:new_file).try(:[], :path) }.compact
Severity: Minor
Found in lib/git_service/diff.rb by rubocop

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if new_file = patch.delta.new_file.try(:[], :path)
Severity: Minor
Found in lib/git_service/diff.rb by rubocop

Checks for assignments in the conditions of if/while/until.

AllowSafeAssignment option for safe assignment. By safe assignment we mean putting parentheses around an assignment to indicate "I know I'm using an assignment as a condition. It's not a mistake."

Safety:

This cop's autocorrection is unsafe because it assumes that the author meant to use an assignment result as a condition.

Example:

# bad
if some_var = true
  do_something
end

# good
if some_var == true
  do_something
end

Example: AllowSafeAssignment: true (default)

# good
if (some_var = true)
  do_something
end

Example: AllowSafeAssignment: false

# bad
if (some_var = true)
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if old_file = patch.delta.old_file.try(:[], :path)
Severity: Minor
Found in lib/git_service/diff.rb by rubocop

Checks for assignments in the conditions of if/while/until.

AllowSafeAssignment option for safe assignment. By safe assignment we mean putting parentheses around an assignment to indicate "I know I'm using an assignment as a condition. It's not a mistake."

Safety:

This cop's autocorrection is unsafe because it assumes that the author meant to use an assignment result as a condition.

Example:

# bad
if some_var = true
  do_something
end

# good
if some_var == true
  do_something
end

Example: AllowSafeAssignment: true (default)

# good
if (some_var = true)
  do_something
end

Example: AllowSafeAssignment: false

# bad
if (some_var = true)
  do_something
end

There are no issues that match your filters.

Category
Status