Sign upLogin

ManageIQ/query_relation

View on GitHub
Star

Showing 4 of 4 total issues

Class QueryRelation has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

class QueryRelation
  extend Forwardable
  include Enumerable
  attr_reader :klass
  attr_accessor :options
Severity: Minor
Found in lib/query_relation.rb - About 4 hrs to fix

    Method where has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def where(*val)
    val = val.flatten.compact
    val = val.first if val.size == 1 && val.first.kind_of?(Hash)
    dup.tap do |r|
      old_where = r.options[:where]
    Severity: Minor
    Found in lib/query_relation.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method merge_hash_or_array has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def merge_hash_or_array(a, b, default = {})
    if a.nil? || a.empty?
      b
    elsif b.nil? || b.empty?
      a
    Severity: Minor
    Found in lib/query_relation.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    metadata['rubygems_mfa_required'] must be set to 'true'.
    Open

    Gem::Specification.new do |spec|
  spec.name          = "query_relation"
  spec.version       = QueryRelation::VERSION
  spec.authors       = ["Keenan Brock", "Jason Frey"]
  spec.email         = ["kbrock@redhat.com", "jfrey@redhat.com"]
    Severity: Minor
    Found in query_relation.gemspec by rubocop

    Requires a gemspec to have rubygems_mfa_required metadata set.

    This setting tells RubyGems that MFA (Multi-Factor Authentication) is required for accounts to be able perform privileged operations, such as (see RubyGems' documentation for the full list of privileged operations):

    • gem push
    • gem yank
    • gem owner --add/remove
    • adding or removing owners using gem ownership page

    This helps make your gem more secure, as users can be more confident that gem updates were pushed by maintainers.

    Example:

    # bad
Gem::Specification.new do |spec|
  # no `rubygems_mfa_required` metadata specified
end

# good
Gem::Specification.new do |spec|
  spec.metadata = {
    'rubygems_mfa_required' => 'true'
  }
end

# good
Gem::Specification.new do |spec|
  spec.metadata['rubygems_mfa_required'] = 'true'
end

# bad
Gem::Specification.new do |spec|
  spec.metadata = {
    'rubygems_mfa_required' => 'false'
  }
end

# good
Gem::Specification.new do |spec|
  spec.metadata = {
    'rubygems_mfa_required' => 'true'
  }
end

# bad
Gem::Specification.new do |spec|
  spec.metadata['rubygems_mfa_required'] = 'false'
end

# good
Gem::Specification.new do |spec|
  spec.metadata['rubygems_mfa_required'] = 'true'
end
    Severity
    Category
    Status
    Source
    Language