Marketcircle/AXElements

View on GitHub

Showing 28 of 28 total issues

Method pp_identifier has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

  def pp_identifier
    # @note use, or lack of use, of #inspect is intentional for visual effect

    if attributes.include? :value
      val = attribute :value
Severity: Minor
Found in lib/accessibility/pretty_printer.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Application has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

class AX::Application < AX::Element
  include Accessibility::String

  class << self
    ##
Severity: Minor
Found in lib/ax/application.rb - About 3 hrs to fix

    File string.rb has 314 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require   'accessibility/version'
    require   'accessibility/key_coder'
    
    ##
    # Parses strings of human readable text into a series of events meant to
    Severity: Minor
    Found in lib/accessibility/string.rb - About 3 hrs to fix

      Class Element has 29 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class AX::Element
        include Accessibility::PrettyPrinter
      
        # @param ref [AXUIElementRef]
        def initialize ref
      Severity: Minor
      Found in lib/ax/element.rb - About 3 hrs to fix

        File dsl.rb has 275 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'active_support/core_ext/object/blank'
        
        require 'mouse'
        require 'ax/element'
        require 'ax/application'
        Severity: Minor
        Found in lib/accessibility/dsl.rb - About 2 hrs to fix

          Method compile! has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            def compile!
              @filters = @criteria.map do |key, value|
                if value.kind_of? Hash
                  [:subsearch, key, value]
                elsif key.kind_of? Array
          Severity: Minor
          Found in lib/accessibility/qualifier.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method lex_custom has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              def lex_custom
                start = @index
                loop do
                  char = @chars[@index]
                  if char == PLUS
          Severity: Minor
          Found in lib/accessibility/string.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            def initialize arg
              case arg
              when Fixnum
                super Accessibility::Element.application_for arg
                @app = NSRunningApplication.runningApplicationWithProcessIdentifier arg
          Severity: Minor
          Found in lib/ax/application.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method to_element has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              def to_element
                if roll = self.role
                  roll = TRANSLATOR.unprefix roll
                  if attributes.include? KAXSubroleAttribute
                    subroll = self.subrole
          Severity: Minor
          Found in lib/accessibility/factory.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method to_ruby has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              def to_ruby
                if roll = self.role
                  roll = TRANSLATOR.unprefix roll
                  if attributes.include? KAXSubroleAttribute
                    subroll = self.subrole
          Severity: Minor
          Found in lib/accessibility/factory.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize arg
              case arg
              when Fixnum
                super Accessibility::Element.application_for arg
                @app = NSRunningApplication.runningApplicationWithProcessIdentifier arg
          Severity: Minor
          Found in lib/ax/application.rb - About 1 hr to fix

            Method perform has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def perform name
                case name
                when :terminate
                  return true if terminated?
                  @app.terminate; spin 0.25; terminated?
            Severity: Minor
            Found in lib/ax/application.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method wait_for_invalidation_of has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def wait_for_invalidation_of element, filters = {}, &block
                timeout = filters[:timeout] || 5
                start   = Time.now
            
                unless element.kind_of? AX::Element
            Severity: Minor
            Found in lib/accessibility/dsl.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def to_element
                  if roll = self.role
                    roll = TRANSLATOR.unprefix roll
                    if attributes.include? KAXSubroleAttribute
                      subroll = self.subrole
            Severity: Minor
            Found in lib/accessibility/factory.rb and 1 other location - About 50 mins to fix
            lib/accessibility/factory.rb on lines 186..201

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def to_ruby
                  if roll = self.role
                    roll = TRANSLATOR.unprefix roll
                    if attributes.include? KAXSubroleAttribute
                      subroll = self.subrole
            Severity: Minor
            Found in lib/accessibility/factory.rb and 1 other location - About 50 mins to fix
            lib/accessibility/factory.rb on lines 152..167

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method application_with_bundle_identifier has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def application_with_bundle_identifier bundle
                $stderr.puts "#{__method__} is DEPRECATED: Use AX::Application.new instead"
                if app_running?(bundle) || launch_application(bundle)
                  10.times do
                    if app_running?(bundle) && (app = try_wrapping(bundle))
            Severity: Minor
            Found in lib/accessibility.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method scroll_to has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def scroll_to element
                Mouse.move_to self.to_point
            
                # calculate which scroll arrow to move to
                fudge_factor = self.item.size.height * 0.1
            Severity: Minor
            Found in lib/ax/menu.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method method_missing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def method_missing method, *args, &block
                return set(method.chomp(EQUALS), args.first) if method[-1] == EQUALS
            
                key = TRANSLATOR.cocoaify method
                if @ref.attributes.include? key
            Severity: Minor
            Found in lib/ax/element.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method gen_nested has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def gen_nested head, tail
                  ((code =   CUSTOM[head]) &&  gen_dynamic(code, tail)) ||
                  ((code =  MAPPING[head]) &&  gen_dynamic(code, tail)) ||
                  ((code =  SHIFTED[head]) &&  gen_shifted(code, tail)) ||
                  ((code = OPTIONED[head]) && gen_optioned(code, tail)) ||
            Severity: Minor
            Found in lib/accessibility/string.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method style has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def style
                  # fill in the node if it is disabled (greyed out effect)
                  if @element.attributes.include?(:enabled)
                    return FILLED unless @element.attribute(:enabled)
                  end
            Severity: Minor
            Found in lib/accessibility/graph.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language