Sign upLogin

Maroc-OS/decompiler

View on GitHub
Star
src/host/ida/ui/browser.py

Summary

Maintainability
A
2 hrs
Test Coverage

Cyclomatic complexity is too high in method select_token. (10)
Open

  def select_token(self):
    """ callback for new selected element in the textedit box. """

    if self.inserting:
        return
Severity: Minor
Found in src/host/ida/ui/browser.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method token_color. (6)
Open

  def token_color(self, token):
    """ get a color according to token type """

    if type(token) == c.token_global:
      return QtGui.QColor(0x4a,0xa3,0xff,255) # light blue
Severity: Minor
Found in src/host/ida/ui/browser.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function select_token has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def select_token(self):
    """ callback for new selected element in the textedit box. """

    if self.inserting:
        return
Severity: Minor
Found in src/host/ida/ui/browser.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def update(self, function):

    self.function = function

    t = c.tokenizer(function)
Severity: Minor
Found in src/host/ida/ui/browser.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return QtGui.QColor(0,0,0,255) # black
Severity: Major
Found in src/host/ida/ui/browser.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return QtGui.QColor(0x87,0x5b,0x4e,255) # brown
    Severity: Major
    Found in src/host/ida/ui/browser.py - About 30 mins to fix

      Line too long (97 > 79 characters)
      Open

          """ given a list of token_fragment objects, set a background brush color for all of them. """
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x4a,0xa3,0xff,255) # light blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      At least two spaces before inline comment
      Open

            return QtGui.QColor(0x20,0x2d,0xae,255) # dark blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

      Indentation is not a multiple of 4
      Open

            return QtGui.QColor(0x00,0xac,0x92,255) # blue-green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

          return QtGui.QColor(0,0,0,255) # black
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

        def set_fragments_bg(self, token_fragments, brush):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

        def token_color(self, token):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      At least two spaces before inline comment
      Open

            return QtGui.QColor(0x00,0xac,0x92,255) # blue-green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

      Indentation is not a multiple of 4
      Open

            token_fragments = [tf for tf in self.__fragments if tf.token in (other, tok)]
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

          brush = QtGui.QBrush(QtGui.QColor(0xff,0xff,0x00,200))
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

            fmt.setProperty(QtGui.QTextFormat.BackgroundBrush, brush)
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            tmpcursor.setPosition(frag.position())
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Line too long (90 > 79 characters)
      Open

            tmpcursor.setPosition(frag.position() + frag.length(), QtGui.QTextCursor.KeepAnchor)
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x00,0xac,0x92,255) # blue-green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      At least two spaces before inline comment
      Open

            return QtGui.QColor(0x87,0x5b,0x4e,255) # brown
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

      Indentation is not a multiple of 4
      Open

            block = block.next()
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

        import PySide
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            frag = tf.fragment
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            return QtGui.QColor(0x4a,0xa3,0xff,255) # light blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            return QtGui.QColor(0x00,0x70,0x00,255) # dark green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x87,0x5b,0x4e,255) # brown
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

          return QtGui.QColor(0,0,0,255) # black
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Expected 2 blank lines, found 1
      Open

      class token_fragment(object):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Indentation is not a multiple of 4
      Open

        def __init__(self, parent=None):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            brush = QtGui.QBrush(QtGui.QColor(0,0,0,0))
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            tmpcursor.setCharFormat(fmt)
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      At least two spaces before inline comment
      Open

            return QtGui.QColor(0x4a,0xa3,0xff,255) # light blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

      Indentation is not a multiple of 4
      Open

            self.insert_token(tok)
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            for it in block:
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            token_fragments = self.__textmap[s]
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x00,0xac,0x92,255) # blue-green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

        print 'PySide not available'
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            self.__current_highlight = None
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

        raise
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            self.set_fragments_bg(self.__current_highlight, brush)
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            return
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x00,0x70,0x00,255) # dark green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

        def update(self, function):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Line too long (83 > 79 characters)
      Open

            token_fragments = [tf for tf in self.__fragments if tf.token in (other, tok)]
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      Missing whitespace after ','
      Open

          brush = QtGui.QBrush(QtGui.QColor(0xff,0xff,0x00,200))
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

            tmpcursor = QtGui.QTextCursor(self.document())
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            return QtGui.QColor(0x87,0x5b,0x4e,255) # brown
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

        def __init__(self, fragment, token):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Expected 2 blank lines, found 1
      Open

      class FlowBrowser(QtGui.QTextEdit):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate top-level function and class definitions with two blank lines.

      Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

      Missing whitespace after ','
      Open

            brush = QtGui.QBrush(QtGui.QColor(0,0,0,0))
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

          brush = QtGui.QBrush(QtGui.QColor(0xff,0xff,0x00,200))
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x4a,0xa3,0xff,255) # light blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Do not use bare 'except'
      Open

      except:
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      When catching exceptions, mention specific exceptions when possible.

      Okay: except Exception:
Okay: except BaseException:
E722: except:

      Indentation is not a multiple of 4
      Open

            return QtGui.QColor(0x20,0x2d,0xae,255) # dark blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x00,0xac,0x92,255) # blue-green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x00,0x70,0x00,255) # dark green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

        def insert_token(self, token):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            brush = QtGui.QBrush(QtGui.QColor(0,0,0,0))
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

            fmt = frag.charFormat()
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x4a,0xa3,0xff,255) # light blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      At least two spaces before inline comment
      Open

            return QtGui.QColor(0x00,0x70,0x00,255) # dark green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x87,0x5b,0x4e,255) # brown
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

          return QtGui.QColor(0,0,0,255) # black
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

            brush = QtGui.QBrush(QtGui.QColor(0,0,0,0))
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

            other = tok.lmatch if type(tok) == c.token_rmatch else tok.rmatch
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x20,0x2d,0xae,255) # dark blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x00,0x70,0x00,255) # dark green
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x87,0x5b,0x4e,255) # brown
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

        def select_token(self):
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            tmpcursor.setPosition(frag.position() + frag.length(), QtGui.QTextCursor.KeepAnchor)
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x20,0x2d,0xae,255) # dark blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      Indentation is not a multiple of 4
      Open

        from PySide import QtCore, QtGui
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Indentation is not a multiple of 4
      Open

            return
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Use indent_size (PEP8 says 4) spaces per indentation level.

      For really old code that you don't want to mess up, you can continue
to use 8-space tabs.

Okay: a = 1
Okay: if a == 0:\n    a = 1
E111:   a = 1
E114:   # a = 1

Okay: for item in items:\n    pass
E112: for item in items:\npass
E115: for item in items:\n# Hi\n    pass

Okay: a = 1\nb = 2
E113: a = 1\n    b = 2
E116: a = 1\n    # b = 2

      Missing whitespace after ','
      Open

            return QtGui.QColor(0x20,0x2d,0xae,255) # dark blue
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Each comma, semicolon or colon should be followed by whitespace.

      Okay: [a, b]
Okay: (3,)
Okay: a[1:4]
Okay: a[:4]
Okay: a[1:]
Okay: a[1:4:2]
E231: ['a','b']
E231: foo(bar,baz)
E231: [{'a':'b'}]

      At least two spaces before inline comment
      Open

          return QtGui.QColor(0,0,0,255) # black
      Severity: Minor
      Found in src/host/ida/ui/browser.py by pep8

      Separate inline comments by at least two spaces.

      An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

      There are no issues that match your filters.

      Category
      Status