Sign upLogin

MarshallAsch/veil-droid

View on GitHub
Star
app/src/main/java/ca/marshallasch/veil/FragmentSignUp.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method onDoneClicked has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void onDoneClicked()
    {
        String firstName = firstNameInput.getText().toString();
        String lastName = lastNameInput.getText().toString();
        String email = emailAddressInput.getText().toString();
Severity: Minor
Found in app/src/main/java/ca/marshallasch/veil/FragmentSignUp.java - About 1 hr to fix

    Method onCreateView has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Nullable
    @Override
    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState)
    {
        View view = inflater.inflate(R.layout.fragment_signup, container, false);
    Severity: Minor
    Found in app/src/main/java/ca/marshallasch/veil/FragmentSignUp.java - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return;
      Severity: Major
      Found in app/src/main/java/ca/marshallasch/veil/FragmentSignUp.java - About 30 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                switch (Util.checkPasswords(password, passwordConf)) {

            case TOO_SIMPLE:
                Snackbar.make(getActivity().findViewById(R.id.top_view), R.string.password_complexity, Snackbar.LENGTH_SHORT).show();
                return;
        Severity: Major
        Found in app/src/main/java/ca/marshallasch/veil/FragmentSignUp.java and 1 other location - About 1 hr to fix
        app/src/main/java/ca/marshallasch/veil/FragmentChangePassword.java on lines 99..112

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status