Sign upLogin

MarshallAsch/veil-droid

View on GitHub
Star
app/src/main/java/ca/marshallasch/veil/HashTableStore.java

Summary

Maintainability
D
2 days
Test Coverage

File HashTableStore.java has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package ca.marshallasch.veil;

import android.content.Context;
import android.support.annotation.NonNull;
import android.support.annotation.Nullable;
Severity: Minor
Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 5 hrs to fix

    Method findUsersByName has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    @Nullable
    public List<Pair<String, DhtProto.User>> findUsersByName(String name)
    {
        if (name == null) {
    Severity: Minor
    Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findCommentsByPost has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        @Deprecated
    @Override
    @NonNull
    public List<DhtProto.Comment> findCommentsByPost(String postHash)
    {
    Severity: Minor
    Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findPostsByKeyword has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
    @Nullable
    public List<DhtProto.Post> findPostsByKeyword(String keyword)
    {
        keyword = keyword.toLowerCase(Locale.getDefault());
    Severity: Minor
    Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method findCommentsByPost has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Deprecated
    @Override
    @NonNull
    public List<DhtProto.Comment> findCommentsByPost(String postHash)
    {
    Severity: Minor
    Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 1 hr to fix

      Method findUsersByName has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @Override
    @Nullable
    public List<Pair<String, DhtProto.User>> findUsersByName(String name)
    {
        if (name == null) {
      Severity: Minor
      Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 1 hr to fix

        Method findPostsByKeyword has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    @Nullable
    public List<DhtProto.Post> findPostsByKeyword(String keyword)
    {
        keyword = keyword.toLowerCase(Locale.getDefault());
        Severity: Minor
        Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 1 hr to fix

          Method insertPost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              @Override
    public String insertPost(DhtProto.Post post)
    {
        if (post == null) {
            return null;
          Severity: Minor
          Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 1 hr to fix

            Method getPostOrComment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                @Nullable
    public DhtProto.DhtWrapper getPostOrComment(String hash) {

        List<DhtProto.DhtWrapper> list = hashMap.get(hash);
            Severity: Minor
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method findPostByHash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
    @Nullable
    public DhtProto.Post findPostByHash(String hash) throws TooManyResultsException
    {
        ArrayList<DhtProto.DhtWrapper> entries;
            Severity: Minor
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method findCommentByHash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
    @Nullable
    public DhtProto.Comment findCommentByHash(String hash) throws TooManyResultsException
    {
        ArrayList<DhtProto.DhtWrapper> entries;
            Severity: Minor
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method findUserByHash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                @Override
    public Pair<String, DhtProto.User> findUserByHash(String userHash) throws TooManyResultsException
    {
        ArrayList<DhtProto.DhtWrapper> entries;
        synchronized (hashMap) {
            Severity: Minor
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @Override
    @Nullable
    public DhtProto.Comment findCommentByHash(String hash) throws TooManyResultsException
    {
        ArrayList<DhtProto.DhtWrapper> entries;
            Severity: Major
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java and 1 other location - About 2 hrs to fix
            app/src/main/java/ca/marshallasch/veil/HashTableStore.java on lines 198..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 134.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @Override
    @Nullable
    public DhtProto.Post findPostByHash(String hash) throws TooManyResultsException
    {
        ArrayList<DhtProto.DhtWrapper> entries;
            Severity: Major
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java and 1 other location - About 2 hrs to fix
            app/src/main/java/ca/marshallasch/veil/HashTableStore.java on lines 380..411

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 134.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for (String tag: titleKeywords) {
            tag = tag.toLowerCase(Locale.getDefault());
            keyword = generateKeyword(title, hash, TITLE_PARTIAL);
            insert(keyword, Util.generateHash(tag.getBytes()));
        }
            Severity: Minor
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java and 1 other location - About 40 mins to fix
            app/src/main/java/ca/marshallasch/veil/HashTableStore.java on lines 168..172

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    for (String tag: tags) {
            tag = tag.toLowerCase(Locale.getDefault());
            keyword = generateKeyword(tag, hash, TAG);
            insert(keyword, Util.generateHash(tag.getBytes()));
        }
            Severity: Minor
            Found in app/src/main/java/ca/marshallasch/veil/HashTableStore.java and 1 other location - About 40 mins to fix
            app/src/main/java/ca/marshallasch/veil/HashTableStore.java on lines 180..184

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status