MarshallAsch/veil-droid

View on GitHub
app/src/main/java/ca/marshallasch/veil/database/Migrations.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method upgradeV10 has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static void upgradeV10(SQLiteDatabase db){

        class KnownPostObject{
            private String postHash;
            private String commentHash;
Severity: Major
Found in app/src/main/java/ca/marshallasch/veil/database/Migrations.java - About 2 hrs to fix

    Method upgradeV8 has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static void upgradeV8(SQLiteDatabase db) {
    
            String[] projection = {
                    KnownPostsContract.KnownPostsEntry.COLUMN_POST_HASH,
                    KnownPostsContract.KnownPostsEntry.COLUMN_COMMENT_HASH,
    Severity: Minor
    Found in app/src/main/java/ca/marshallasch/veil/database/Migrations.java - About 1 hr to fix

      Method upgradeV7 has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static void upgradeV7(SQLiteDatabase db) {
      
              List<Pair<String, String>> knownPosts = new ArrayList<>();
      
      
      
      Severity: Minor
      Found in app/src/main/java/ca/marshallasch/veil/database/Migrations.java - About 1 hr to fix

        Method upgradeV6 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static void upgradeV6(SQLiteDatabase db){
        
                // need to get the old values from the table
                List<Pair<String, String>> knownPosts = new ArrayList<>();
        
        
        Severity: Minor
        Found in app/src/main/java/ca/marshallasch/veil/database/Migrations.java - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  while(cursor.moveToNext()) {
                      postHash = cursor.getString(cursor.getColumnIndexOrThrow(KnownPostsContract.KnownPostsEntry.COLUMN_POST_HASH));
                      commentHash = cursor.getString(cursor.getColumnIndexOrThrow(KnownPostsContract.KnownPostsEntry.COLUMN_COMMENT_HASH));
          
                      // add the hash to the list
          Severity: Minor
          Found in app/src/main/java/ca/marshallasch/veil/database/Migrations.java and 1 other location - About 50 mins to fix
          app/src/main/java/ca/marshallasch/veil/database/Migrations.java on lines 64..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  while(cursor.moveToNext()) {
                      postHash = cursor.getString(cursor.getColumnIndexOrThrow(KnownPostsContract.KnownPostsEntry.COLUMN_POST_HASH));
                      commentHash = cursor.getString(cursor.getColumnIndexOrThrow(KnownPostsContract.KnownPostsEntry.COLUMN_COMMENT_HASH));
          
                      // add the hash to the list
          Severity: Minor
          Found in app/src/main/java/ca/marshallasch/veil/database/Migrations.java and 1 other location - About 50 mins to fix
          app/src/main/java/ca/marshallasch/veil/database/Migrations.java on lines 120..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status