MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-

View on GitHub

Showing 446 of 446 total issues

Function receiverFn has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  new Promise((resolve, reject) => {
    let dialog = document.createElement('paper-dialog');
    trigID++;
    const body = document.getElementsByTagName('body')[0];
    const title = 'Choose Cast Device'; // TODO: New translate key needed
Severity: Major
Found in src/renderer/windows/GPMWebView/chromecast.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (!label) {
              switch (device.deviceId) {
                case 'default':
                  label = TranslationProvider.query('audio-device-default');
                  break;
    Severity: Major
    Found in src/renderer/ui/components/settings/AudioDeviceSelector.js and 1 other location - About 2 hrs to fix
    src/main/features/core/tray.js on lines 245..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function connect has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      connect: (extensionId) => {
        const createChannel = (label) => { // eslint-disable-line
          const fns = [];
          return {
            addListener: (...args) => {
    Severity: Minor
    Found in src/renderer/windows/GPMWebView/runtime.js - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if (!label) {
              switch (device.deviceId) {
                case 'default':
                  label = TranslationProvider.query('audio-device-default');
                  break;
      Severity: Major
      Found in src/main/features/core/tray.js and 1 other location - About 2 hrs to fix
      src/renderer/ui/components/settings/AudioDeviceSelector.js on lines 46..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        fireSync(event, ...details) {
          if (this.ready) {
            ipcRenderer.sendSync(event, ...details);
          } else {
            this.q.push(this.fireSync.bind(this, event, ...details));
      Severity: Major
      Found in src/renderer/rendererEmitter.js and 1 other location - About 1 hr to fix
      src/renderer/rendererEmitter.js on lines 52..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        _unhook() {
          Emitter.off('lyrics:show', this.show);
          Emitter.off('PlaybackAPI:change:lyrics', this.lyricsHandler);
          Emitter.off('PlaybackAPI:change:state', this.stateHandler);
          Emitter.off('settings:set:scrollLyrics', this.scrollSettingsHandler);
      Severity: Major
      Found in src/renderer/ui/components/generic/LyricsViewer.js and 3 other locations - About 1 hr to fix
      src/renderer/ui/components/generic/LyricsViewer.js on lines 125..130
      src/renderer/ui/components/generic/WindowContainer.js on lines 32..37
      src/renderer/ui/components/generic/WindowContainer.js on lines 39..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          ipcRenderer.once(event, (internalEvent, ...internalDetails) => {
            if (this.ready) {
              this._call(fn, internalEvent, ...internalDetails);
            } else {
              this.q.push(this._call.bind(this, fn, internalEvent, ...internalDetails));
      Severity: Major
      Found in src/renderer/rendererEmitter.js and 1 other location - About 1 hr to fix
      src/renderer/rendererEmitter.js on lines 103..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          const internalMethod = (internalEvent, ...internalDetails) => {
            if (this.ready) {
              this._call(fn, internalEvent, ...internalDetails);
            } else {
              this.q.push(this._call.bind(this, fn, internalEvent, ...internalDetails));
      Severity: Major
      Found in src/renderer/rendererEmitter.js and 1 other location - About 1 hr to fix
      src/renderer/rendererEmitter.js on lines 116..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        componentDidMount() {
          Emitter.on('settings:change:theme', this._themeUpdate);
          Emitter.on('settings:change:themeColor', this._themeColorUpdate);
          Emitter.on('settings:change:themeType', this._themeTypeUpdate);
          Emitter.on('window:changefullscreen', this._updateFullscreen);
      Severity: Major
      Found in src/renderer/ui/components/generic/WindowContainer.js and 3 other locations - About 1 hr to fix
      src/renderer/ui/components/generic/LyricsViewer.js on lines 125..130
      src/renderer/ui/components/generic/LyricsViewer.js on lines 132..137
      src/renderer/ui/components/generic/WindowContainer.js on lines 39..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        componentWillUnmount() {
          Emitter.off('settings:change:theme', this._themeUpdate);
          Emitter.off('settings:change:themeColor', this._themeColorUpdate);
          Emitter.off('settings:change:themeType', this._themeTypeUpdate);
          Emitter.off('window:changefullscreen', this._updateFullscreen);
      Severity: Major
      Found in src/renderer/ui/components/generic/WindowContainer.js and 3 other locations - About 1 hr to fix
      src/renderer/ui/components/generic/LyricsViewer.js on lines 125..130
      src/renderer/ui/components/generic/LyricsViewer.js on lines 132..137
      src/renderer/ui/components/generic/WindowContainer.js on lines 32..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        fire(event, ...details) {
          if (this.ready) {
            ipcRenderer.send(event, ...details);
          } else {
            this.q.push(this.fire.bind(this, event, ...details));
      Severity: Major
      Found in src/renderer/rendererEmitter.js and 1 other location - About 1 hr to fix
      src/renderer/rendererEmitter.js on lines 60..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        _hook() {
          Emitter.on('lyrics:show', this.show);
          Emitter.on('PlaybackAPI:change:lyrics', this.lyricsHandler);
          Emitter.on('PlaybackAPI:change:state', this.stateHandler);
          Emitter.on('settings:set:scrollLyrics', this.scrollSettingsHandler);
      Severity: Major
      Found in src/renderer/ui/components/generic/LyricsViewer.js and 3 other locations - About 1 hr to fix
      src/renderer/ui/components/generic/LyricsViewer.js on lines 132..137
      src/renderer/ui/components/generic/WindowContainer.js on lines 32..37
      src/renderer/ui/components/generic/WindowContainer.js on lines 39..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const handleSwipeCommand = (e, direction) => {
        if (direction === 'left') {
          remote.getCurrentWebContents().goBack();
        } else if (direction === 'right') {
          remote.getCurrentWebContents().goForward();
      src/renderer/windows/GPMWebView/interface/generic/customNavigation/mouseButtonNavigation.js on lines 3..9

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const handleAppCommand = (e, cmd) => {
        if (cmd === 'browser-backward') {
          remote.getCurrentWebContents().goBack();
        } else if (cmd === 'browser-forward') {
          remote.getCurrentWebContents().goForward();
      src/renderer/windows/GPMWebView/interface/generic/customNavigation/mouseButtonNavigation.js on lines 11..17

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function constructor has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor() {
          let ready = true;
          this.__defineGetter__('ready', () => ready);
          this.__defineSetter__('ready', (newValue) => {
            ready = newValue;
      Severity: Minor
      Found in src/renderer/rendererEmitter.js - About 1 hr to fix

        Function waitForBody has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const waitForBody = setInterval(() => {
          if (document.body) {
            clearInterval(waitForBody);
            document.querySelectorAll('.top-bar')[0].setAttribute('style', '-webkit-app-region: drag');
            setInterval(() => {
        Severity: Minor
        Found in src/renderer/lastFM.js - About 1 hr to fix

          Function setUpAutoUpdate has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const setUpAutoUpdate = () => {
            if (global.DEV_MODE) return;
            try {
              autoUpdater.setFeedURL(`https://update.gpmdp.xyz/update/${platform}/${app.getVersion()}`);
          
          
          Severity: Minor
          Found in src/main/features/core/autoUpdater.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

            if ((osVersion[0] && parseInt(osVersion[0], 10) > 6) || (parseInt(osVersion[0], 10) === 6 && parseInt(osVersion[1], 10) > 1)) {
              // If we are above windows 7 we can use the system notifications but with
              // the silent flag forced on
              require('../silent_Notification');
            } else {
            Severity: Critical
            Found in src/renderer/generic/win32/polyfill_Notification.js - About 1 hr to fix

              Line 170 exceeds the maximum line length of 160.
              Open

              Severity: Minor
              Found in gulpfile.babel.js by eslint

              enforce a maximum line length (max-len)

              Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

              var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

              Rule Details

              This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

              Options

              This rule has a number or object option:

              • "code" (default 80) enforces a maximum line length
              • "tabWidth" (default 4) specifies the character width for tab characters
              • "comments" enforces a maximum line length for comments; defaults to value of code
              • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
              • "ignoreComments": true ignores all trailing comments and comments on their own line
              • "ignoreTrailingComments": true ignores only trailing comments
              • "ignoreUrls": true ignores lines that contain a URL
              • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
              • "ignoreTemplateLiterals": true ignores lines that contain a template literal
              • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

              code

              Examples of incorrect code for this rule with the default { "code": 80 } option:

              /*eslint max-len: ["error", 80]*/
              
              var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

              Examples of correct code for this rule with the default { "code": 80 } option:

              /*eslint max-len: ["error", 80]*/
              
              var foo = {
                "bar": "This is a bar.",
                "baz": { "qux": "This is a qux" },
                "easier": "to read"
              };

              tabWidth

              Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

              /*eslint max-len: ["error", 80, 4]*/
              
              \t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

              Examples of correct code for this rule with the default { "tabWidth": 4 } option:

              /*eslint max-len: ["error", 80, 4]*/
              
              \t  \t  var foo = {
              \t  \t  \t  \t  "bar": "This is a bar.",
              \t  \t  \t  \t  "baz": { "qux": "This is a qux" }
              \t  \t  };

              comments

              Examples of incorrect code for this rule with the { "comments": 65 } option:

              /*eslint max-len: ["error", { "comments": 65 }]*/
              
              /**
               * This is a comment that violates the maximum line length we have specified
              **/

              ignoreComments

              Examples of correct code for this rule with the { "ignoreComments": true } option:

              /*eslint max-len: ["error", { "ignoreComments": true }]*/
              
              /**
               * This is a really really really really really really really really really long comment
              **/

              ignoreTrailingComments

              Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

              /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/
              
              var foo = 'bar'; // This is a really really really really really really really long comment

              ignoreUrls

              Examples of correct code for this rule with the { "ignoreUrls": true } option:

              /*eslint max-len: ["error", { "ignoreUrls": true }]*/
              
              var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

              ignoreStrings

              Examples of correct code for this rule with the { "ignoreStrings": true } option:

              /*eslint max-len: ["error", { "ignoreStrings": true }]*/
              
              var longString = 'this is a really really really really really long string!';

              ignoreTemplateLiterals

              Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

              /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/
              
              var longTemplateLiteral = `this is a really really really really really long template literal!`;

              ignoreRegExpLiterals

              Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

              /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/
              
              var longRegExpLiteral = /this is a really really really really really long regular expression!/;

              ignorePattern

              Examples of correct code for this rule with the { "ignorePattern": true } option:

              /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/
              
              var dep = require('really/really/really/really/really/really/really/really/long/module');

              Related Rules

              • [complexity](complexity.md)
              • [max-depth](max-depth.md)
              • [max-nested-callbacks](max-nested-callbacks.md)
              • [max-params](max-params.md)
              • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

              Line 102 exceeds the maximum line length of 160.
              Open

                          <header className="darwin-title-bar" onDoubleClick={this._darwinExpand} style={{ backgroundColor: muiTheme.tabs.backgroundColor, height: this.state.isFullscreen ? 0 : 23 }}>

              enforce a maximum line length (max-len)

              Very long lines of code in any language can be difficult to read. In order to aid in readability and maintainability many coders have developed a convention to limit lines of code to X number of characters (traditionally 80 characters).

              var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" }; // very long

              Rule Details

              This rule enforces a maximum line length to increase code readability and maintainability. The length of a line is defined as the number of Unicode characters in the line.

              Options

              This rule has a number or object option:

              • "code" (default 80) enforces a maximum line length
              • "tabWidth" (default 4) specifies the character width for tab characters
              • "comments" enforces a maximum line length for comments; defaults to value of code
              • "ignorePattern" ignores lines matching a regular expression; can only match a single line and need to be double escaped when written in YAML or JSON
              • "ignoreComments": true ignores all trailing comments and comments on their own line
              • "ignoreTrailingComments": true ignores only trailing comments
              • "ignoreUrls": true ignores lines that contain a URL
              • "ignoreStrings": true ignores lines that contain a double-quoted or single-quoted string
              • "ignoreTemplateLiterals": true ignores lines that contain a template literal
              • "ignoreRegExpLiterals": true ignores lines that contain a RegExp literal

              code

              Examples of incorrect code for this rule with the default { "code": 80 } option:

              /*eslint max-len: ["error", 80]*/
              
              var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" }, "difficult": "to read" };

              Examples of correct code for this rule with the default { "code": 80 } option:

              /*eslint max-len: ["error", 80]*/
              
              var foo = {
                "bar": "This is a bar.",
                "baz": { "qux": "This is a qux" },
                "easier": "to read"
              };

              tabWidth

              Examples of incorrect code for this rule with the default { "tabWidth": 4 } option:

              /*eslint max-len: ["error", 80, 4]*/
              
              \t  \t  var foo = { "bar": "This is a bar.", "baz": { "qux": "This is a qux" } };

              Examples of correct code for this rule with the default { "tabWidth": 4 } option:

              /*eslint max-len: ["error", 80, 4]*/
              
              \t  \t  var foo = {
              \t  \t  \t  \t  "bar": "This is a bar.",
              \t  \t  \t  \t  "baz": { "qux": "This is a qux" }
              \t  \t  };

              comments

              Examples of incorrect code for this rule with the { "comments": 65 } option:

              /*eslint max-len: ["error", { "comments": 65 }]*/
              
              /**
               * This is a comment that violates the maximum line length we have specified
              **/

              ignoreComments

              Examples of correct code for this rule with the { "ignoreComments": true } option:

              /*eslint max-len: ["error", { "ignoreComments": true }]*/
              
              /**
               * This is a really really really really really really really really really long comment
              **/

              ignoreTrailingComments

              Examples of correct code for this rule with the { "ignoreTrailingComments": true } option:

              /*eslint max-len: ["error", { "ignoreTrailingComments": true }]*/
              
              var foo = 'bar'; // This is a really really really really really really really long comment

              ignoreUrls

              Examples of correct code for this rule with the { "ignoreUrls": true } option:

              /*eslint max-len: ["error", { "ignoreUrls": true }]*/
              
              var url = 'https://www.example.com/really/really/really/really/really/really/really/long';

              ignoreStrings

              Examples of correct code for this rule with the { "ignoreStrings": true } option:

              /*eslint max-len: ["error", { "ignoreStrings": true }]*/
              
              var longString = 'this is a really really really really really long string!';

              ignoreTemplateLiterals

              Examples of correct code for this rule with the { "ignoreTemplateLiterals": true } option:

              /*eslint max-len: ["error", { "ignoreTemplateLiterals": true }]*/
              
              var longTemplateLiteral = `this is a really really really really really long template literal!`;

              ignoreRegExpLiterals

              Examples of correct code for this rule with the { "ignoreRegExpLiterals": true } option:

              /*eslint max-len: ["error", { "ignoreRegExpLiterals": true }]*/
              
              var longRegExpLiteral = /this is a really really really really really long regular expression!/;

              ignorePattern

              Examples of correct code for this rule with the { "ignorePattern": true } option:

              /*eslint max-len: ["error", { "ignorePattern": "^\\s*var\\s.+=\\s*require\\s*\\(/" }]*/
              
              var dep = require('really/really/really/really/really/really/really/really/long/module');

              Related Rules

              • [complexity](complexity.md)
              • [max-depth](max-depth.md)
              • [max-nested-callbacks](max-nested-callbacks.md)
              • [max-params](max-params.md)
              • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/
              Severity
              Category
              Status
              Source
              Language