MartinMalinda/vue-concurrency

View on GitHub

Showing 10 of 10 total issues

Function createTaskInstance has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function createTaskInstance<T>(
  cb: TaskCb<T, any>,
  params: any[],
  options: TaskInstanceOptions
): TaskInstance<T> {
Severity: Major
Found in src/TaskInstance.ts - About 3 hrs to fix

    Function useTask has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function useTask<T, U extends any[]>(
      cb: TaskCb<T, U>,
      options = { cancelOnUnmount: true }
    ): Task<Resolved<T>, U> {
      const vm = getCurrentInstance();
    Severity: Minor
    Found in src/Task.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    content has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

      const content = _reactiveContent({
        _isRestartable: false,
        _isDropping: false,
        _isEnqueuing: false,
        _isKeepingLatest: false,
    Severity: Minor
    Found in src/Task.ts - About 2 hrs to fix

      Function createTaskInstance has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function createTaskInstance<T>(
        cb: TaskCb<T, any>,
        params: any[],
        options: TaskInstanceOptions
      ): TaskInstance<T> {
      Severity: Minor
      Found in src/TaskInstance.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function printTask has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      export function printTask(task: Task<any, any>) {
        let taskType = "General";
      
        if (task._isDropping) {
          taskType = "Drop";
      Severity: Minor
      Found in src/utils/general.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function printTask has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function printTask(task: Task<any, any>) {
        let taskType = "General";
      
        if (task._isDropping) {
          taskType = "Drop";
      Severity: Minor
      Found in src/utils/general.ts - About 1 hr to fix

        Function runTaskInstance has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function runTaskInstance<T>(
          taskInstance: TaskInstance<any>,
          cb: TaskCb<T, any>,
          params: any[],
          options: TaskInstanceOptions
        Severity: Minor
        Found in src/TaskInstance.ts - About 1 hr to fix

          Function perform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              perform(...params) {
                const modifiers: ModifierOptions = {
                  enqueue: false,
                  drop: false,
                };
          Severity: Minor
          Found in src/Task.ts - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              ['vue-concurrency.modern.js', 'vue-concurrency.module.js'].forEach(fileName => {
                replaceInFile(path.join(dir, 'dist', 'vue3', fileName), `from"vue3"`, `from"vue"`);
              });
            Severity: Minor
            Found in scripts/fixVue3Import.js and 1 other location - About 45 mins to fix
            scripts/fixVue3Import.js on lines 24..26

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              ['vue-concurrency.js', 'vue-concurrency.umd.js'].forEach(fileName => {
                replaceInFile(path.join(dir, 'dist', 'vue3', fileName), `require("vue3")`, `require("vue")`);
              });
            Severity: Minor
            Found in scripts/fixVue3Import.js and 1 other location - About 45 mins to fix
            scripts/fixVue3Import.js on lines 20..22

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language