Sign upLogin

MasatoMakino/pixijs-basic-scrollbar

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const scrollbar = new ScrollBarView(
    {
      base: getScrollBarBase(SCROLLBAR_W, SCROLLBAR_H, 0x0000ff),
      button: getScrollBarButton(SCROLLBAR_W, 0xffff00),
      minPosition: 0,
Severity: Major
Found in demoSrc/demo_scrollbar.js and 1 other location - About 1 hr to fix
demoSrc/demo_scrollbar_horizontal.js on lines 33..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const scrollbar = new ScrollBarView(
    {
      base: getScrollBarBase(SCROLLBAR_W, SCROLLBAR_H, 0x0000ff),
      button: getScrollBarButton(SCROLLBAR_H, 0xffff00),
      minPosition: 0,
Severity: Major
Found in demoSrc/demo_scrollbar_horizontal.js and 1 other location - About 1 hr to fix
demoSrc/demo_scrollbar.js on lines 57..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function onDomContentsLoaded has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const onDomContentsLoaded = async () => {
  const app = new Application();
  await app.init({ width: 800, height: 800 });

  document.body.appendChild(app.canvas);
Severity: Minor
Found in demoSrc/demo_scrollbar.js - About 1 hr to fix

    Function initScrollBar has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const initScrollBar = (stage, view) => {
  const SCROLLBAR_W = 16;
  const SCROLLBAR_H = 360;
  const SCROLLBAR_Y = 120;
  const CONTENTS_W = 240;
    Severity: Minor
    Found in demoSrc/demo_scrollbar.js - About 1 hr to fix

      Function initScrollBar has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const initScrollBar = (stage, view) => {
  const SCROLLBAR_W = 360;
  const SCROLLBAR_H = 16;
  const SCROLLBAR_Y = 120;
  const CONTENTS_SIZE = 160;
      Severity: Minor
      Found in demoSrc/demo_scrollbar_horizontal.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          static addEventListenerToTarget(
    target: Container | HTMLCanvasElement,
    event: keyof ContainerEvents,
    listener: EventEmitter.ListenerFn,
  ) {
        Severity: Minor
        Found in src/SliderViewUtil.ts and 1 other location - About 55 mins to fix
        src/SliderViewUtil.ts on lines 204..210

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          static removeEventListenerFromTarget(
    target: Container | HTMLCanvasElement,
    event: keyof ContainerEvents,
    listener: EventEmitter.ListenerFn,
  ) {
        Severity: Minor
        Found in src/SliderViewUtil.ts and 1 other location - About 55 mins to fix
        src/SliderViewUtil.ts on lines 196..202

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language