MatteoRagni/cas-rb

View on GitHub

Showing 1,530 of 1,530 total issues

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      @lower_str   = @upper_str   = "≤"
Severity: Minor
Found in lib/functions/fnc-box-conditions.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use && instead of and.
Open

      return CAS.const(self.call({})) if (@x.is_a? CAS::Constant and @y.is_a? CAS::Constant)
Severity: Minor
Found in lib/functions/fnc-base.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Use && instead of and.
Open

      return self if (@x == CAS::Zero and @y == CAS::Infinity)
Severity: Minor
Found in lib/functions/fnc-base.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if diff_y == CAS::Zero
Severity: Minor
Found in lib/functions/fnc-base.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Don't use parentheses around the condition of an if.
Open

      return self if (@x == CAS::Infinity and @y == CAS::Zero)
Severity: Minor
Found in lib/functions/fnc-base.rb by rubocop

This cop checks for the presence of superfluous parentheses around the condition of if/unless/while/until.

Example:

# bad
x += 1 while (x < 10)
foo unless (bar || baz)

if (x > 10)
elsif (x < 3)
end

# good
x += 1 while x < 10
foo unless bar || baz

if x > 10
elsif x < 3
end

Useless assignment to variable - t. Use * instead of *=.
Open

        [cs.inject { |t, c| t *= c.call({}) }] + xs
Severity: Minor
Found in lib/functions/fnc-prod.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if @x.depend? v
Severity: Minor
Found in lib/functions/fnc-trsc.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Do not place comments on the same line as the end keyword.
Open

  end # SmallerEqual
Severity: Minor
Found in lib/functions/fnc-conditions.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Redundant return detected.
Open

      return ((@x == op.x) and (@y == op.y) and (self.class == op.class))
Severity: Minor
Found in lib/functions/fnc-conditions.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Use alias arccos acos instead of alias :arccos :acos.
Open

    alias :arccos :acos
Severity: Minor
Found in lib/functions/fnc-trig.rb by rubocop

This cop enforces the use of either #alias or #alias_method depending on configuration. It also flags uses of alias :symbol rather than alias bareword.

Example: EnforcedStyle: prefer_alias (default)

# bad
alias_method :bar, :foo
alias :bar :foo

# good
alias bar foo

Example: EnforcedStyle: preferaliasmethod

# bad
alias :bar :foo
alias bar foo

# good
alias_method :bar, :foo

Redundant return detected.
Open

      return self
Severity: Minor
Found in lib/functions/fnc-conditions.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Line is too long. [81/80]
Open

    #  d  |  f(x)   if condition(x) is True     | f'(x)   if condition(x) is True
Severity: Minor
Found in lib/functions/fnc-piecewise.rb by rubocop

Line is too long. [98/80]
Open

  # Min class represent a piecewise in which the condition is `f(x) ≤ g(x)`. Derivate a `CAS::Min`
Severity: Minor
Found in lib/functions/fnc-piecewise.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      if self.class != op.class
Severity: Minor
Found in lib/functions/fnc-piecewise.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Use only ascii symbols in comments.
Open

  # a < f(x) ≤ b
Severity: Minor
Found in lib/functions/fnc-box-conditions.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

Do not place comments on the same line as the end keyword.
Open

  end # BoxConditionUpperClosed
Severity: Minor
Found in lib/functions/fnc-box-conditions.rb by rubocop

This cop checks for comments put on the same line as some keywords. These keywords are: begin, class, def, end, module.

Note that some comments (such as :nodoc: and rubocop:disable) are allowed.

Example:

# bad
if condition
  statement
end # end if

# bad
class X # comment
  statement
end

# bad
def x; end # comment

# good
if condition
  statement
end

# good
class X # :nodoc:
  y
end

Redundant return detected.
Open

      return self
Severity: Minor
Found in lib/functions/fnc-box-conditions.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Space around operator ** detected.
Open

        return (@x ** @y) * ((diff_y * CAS.ln(@x)) + (@y * diff_x / @x))
Severity: Minor
Found in lib/functions/fnc-base.rb by rubocop

Checks that operators have space around them, except for ** which should not have surrounding space.

Example:

# bad
total = 3*4
"apple"+"juice"
my_number = 38/4
a ** b

# good
total = 3 * 4
"apple" + "juice"
my_number = 38 / 4
a**b

Line is too long. [89/80]
Open

    #  * **returns**: `String` that represent Ruby code to be parsed in `CAS::Op#to_proc`
Severity: Minor
Found in lib/functions/fnc-base.rb by rubocop

Use && instead of and.
Open

      return self if (@x == CAS::Infinity and @y == CAS::Zero)
Severity: Minor
Found in lib/functions/fnc-base.rb by rubocop

This cop checks for uses of and and or, and suggests using && and || instead. It can be configured to check only in conditions, or in all contexts.

Example: EnforcedStyle: always (default)

# bad
foo.save and return

# bad
if foo and bar
end

# good
foo.save && return

# good
if foo && bar
end

Example: EnforcedStyle: conditionals

# bad
if foo and bar
end

# good
foo.save && return

# good
foo.save and return

# good
if foo && bar
end
Severity
Category
Status
Source
Language