Sign upLogin

MatthewMi11er/wordpress-plugin-mi11er-utility

View on GitHub
Star
includes/mi11er-utility/class-author-slug.php

Summary

Maintainability
A
0 mins
Test Coverage

pre_user_nicename_filter accesses the super-global variable $_REQUEST.
Open

    public function pre_user_nicename_filter( $user_nicename ) {
        return isset( $_REQUEST['display_name'] ) ? sanitize_title( wp_unslash( $_REQUEST['display_name'] ) ) : $user_nicename; // WPCS: input var ok.
    }
Severity: Minor
Found in includes/mi11er-utility/class-author-slug.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

pre_user_nicename_filter accesses the super-global variable $_REQUEST.
Open

    public function pre_user_nicename_filter( $user_nicename ) {
        return isset( $_REQUEST['display_name'] ) ? sanitize_title( wp_unslash( $_REQUEST['display_name'] ) ) : $user_nicename; // WPCS: input var ok.
    }
Severity: Minor
Found in includes/mi11er-utility/class-author-slug.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

TODO found
Open

 * @TODO refactor using more robust methods.
Severity: Minor
Found in includes/mi11er-utility/class-author-slug.php by fixme

The class Author_Slug is not named in CamelCase.
Open

class Author_Slug implements Plugin_Interface
{
    /**
     * Run whatever is needed for plugin setup
     */
Severity: Minor
Found in includes/mi11er-utility/class-author-slug.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The parameter $user_nicename is not named in camelCase.
Open

    public function pre_user_nicename_filter( $user_nicename ) {
        return isset( $_REQUEST['display_name'] ) ? sanitize_title( wp_unslash( $_REQUEST['display_name'] ) ) : $user_nicename; // WPCS: input var ok.
    }
Severity: Minor
Found in includes/mi11er-utility/class-author-slug.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The method pre_user_nicename_filter is not named in camelCase.
Open

    public function pre_user_nicename_filter( $user_nicename ) {
        return isset( $_REQUEST['display_name'] ) ? sanitize_title( wp_unslash( $_REQUEST['display_name'] ) ) : $user_nicename; // WPCS: input var ok.
    }
Severity: Minor
Found in includes/mi11er-utility/class-author-slug.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status