Sign upLogin

MatthewMi11er/wordpress-plugin-mi11er-utility

View on GitHub
Star
includes/mi11er-utility/class-site-icons.php

Summary

Maintainability
A
0 mins
Test Coverage

The class Site_Icons has 11 public methods. Consider refactoring Site_Icons to keep number of public methods under 10.
Open

class Site_Icons implements Plugin_Interface
{
    /**
     * List of Icons
     *
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Missing class import via use statement (line '225', column '14').
Open

            throw new \UnexpectedValueException( $icon_name . ' is not a known Icon' );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'get_the_site_icon_url',    [ $this, 'get_the_site_icon_url' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'the_application_tooltip',  [ $this, 'the_application_tooltip' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="144x144" href="<?php TT::the_site_icon_url( 'apple-touch-icon-144x144.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="180x180" href="<?php TT::the_site_icon_url( 'apple-touch-icon-180x180.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="mask-icon" href="<?php TT::the_site_icon_url( 'safari-pinned-tab.svg' ); ?>" color="#5bbad5">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <meta name="apple-mobile-web-app-title" content="<?php TT::the_site_name(); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <meta name="msapplication-TileColor" content="<?php TT::the_site_icon_tile_color(); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <meta name="theme-color" content="<?php TT::the_theme_color(); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="60x60" href="<?php TT::the_site_icon_url( 'apple-touch-icon-60x60.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'the_site_icon_tile_color', [ $this, 'the_site_icon_tile_color' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'the_site_name',            [ $this, 'the_site_name' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="icon" type="image/png" href="<?php TT::the_site_icon_url( 'android-chrome-192x192.png' ); ?>" sizes="192x192">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <meta name="msapplication-tooltip" content="<?php TT::the_application_tooltip(); ?>" />
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'the_theme_color',          [ $this, 'the_theme_color' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'the_site_icon_url',        [ $this, 'the_site_icon_url' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="manifest" href="<?php TT::the_home_url( '/manifest.json' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <meta name="msapplication-TileImage" content="<?php TT::the_site_icon_url( 'mstile-144x144.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'get_the_site_name',        [ $this, 'get_the_site_name' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="icon" type="image/png" href="<?php TT::the_site_icon_url( 'favicon-32x32.png' ); ?>" sizes="32x32">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'setup'.
Open

        TT::add_tag( 'the_icon_links',           [ $this, 'the_icon_links' ] );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="57x57" href="<?php TT::the_site_icon_url( 'apple-touch-icon-57x57.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="114x114" href="<?php TT::the_site_icon_url( 'apple-touch-icon-114x114.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="icon" type="image/png" href="<?php TT::the_site_icon_url( 'favicon-16x16.png' ); ?>" sizes="16x16">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'mu_file_handler_action'.
Open

        $template_directory = trailingslashit( TT::get_mu_template_directory() );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'get_the_site_icon_url'.
Open

        $icon_file = TT::get_the_root_directory() . $icon_name;
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_site_name'.
Open

        echo esc_attr( TT::get_the_site_name() );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="72x72" href="<?php TT::the_site_icon_url( 'apple-touch-icon-72x72.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="shortcut icon" href="<?php TT::the_site_icon_url( 'favicon.ico' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <meta name="application-name" content="<?php TT::the_site_name(); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="76x76" href="<?php TT::the_site_icon_url( 'apple-touch-icon-76x76.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="icon" type="image/png" href="<?php TT::the_site_icon_url( 'favicon-96x96.png' ); ?>" sizes="96x96">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_site_icon_url'.
Open

        echo esc_url( TT::get_the_site_icon_url( $icon_name ) );
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="152x152" href="<?php TT::the_site_icon_url( 'apple-touch-icon-152x152.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Mi11er\Utility\Template_Tags' in method 'the_icon_links'.
Open

    <link rel="apple-touch-icon" sizes="120x120" href="<?php TT::the_site_icon_url( 'apple-touch-icon-120x120.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$value'.
Open

    public static function option_site_icon_filter( $value ) {
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

TODO found
Open

     * TODO: maskicon color
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by fixme

TODO found
Open

     * TODO: theme-color
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by fixme

TODO found
Open

     * TODO: File Names
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by fixme

The parameter $icon_name is not named in camelCase.
Open

    public function the_site_icon_url( $icon_name ) {
        echo esc_url( TT::get_the_site_icon_url( $icon_name ) );
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The class Site_Icons is not named in CamelCase.
Open

class Site_Icons implements Plugin_Interface
{
    /**
     * List of Icons
     *
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The property $_icons is not named in camelCase.
Open

class Site_Icons implements Plugin_Interface
{
    /**
     * List of Icons
     *
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

The parameter $icon_name is not named in camelCase.
Open

    public function get_the_site_icon_url( $icon_name ) {
        if ( ! in_array( $icon_name , $this->_icons, true ) ) {
            throw new \UnexpectedValueException( $icon_name . ' is not a known Icon' );
        }
        $query_string = '';
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $wp_customize is not named in camelCase.
Open

    public function customize_register_action( $wp_customize ) {
        /**
         * Since we're over ridding them...
         * Remove the default wp-site-icon settings in the Customizer.
         *
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $file_handler is not named in camelCase.
Open

    public function mu_file_handler_action( $file_handler ) {
        $template_directory = trailingslashit( TT::get_mu_template_directory() );
        $file_handler->add_config( 'browserconfig.xml', '^browserconfig\.xml$', $template_directory . 'browserconfig.php' , true );
        $file_handler->add_config( 'manifest.json',     '^manifest\.json$',     $template_directory . 'manifest.php',       true );
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The method customize_register_action is not named in camelCase.
Open

    public function customize_register_action( $wp_customize ) {
        /**
         * Since we're over ridding them...
         * Remove the default wp-site-icon settings in the Customizer.
         *
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method wp_head_action is not named in camelCase.
Open

    public function wp_head_action() {
        // Display our icons in the header.
        $this->the_icon_links();
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method the_site_icon_tile_color is not named in camelCase.
Open

    public function the_site_icon_tile_color() {
        /**
         * Filter the icon tile color
         *
         * @param string The icon color.
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method mu_file_handler_action is not named in camelCase.
Open

    public function mu_file_handler_action( $file_handler ) {
        $template_directory = trailingslashit( TT::get_mu_template_directory() );
        $file_handler->add_config( 'browserconfig.xml', '^browserconfig\.xml$', $template_directory . 'browserconfig.php' , true );
        $file_handler->add_config( 'manifest.json',     '^manifest\.json$',     $template_directory . 'manifest.php',       true );
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method option_site_icon_filter is not named in camelCase.
Open

    public static function option_site_icon_filter( $value ) {
        return 0;
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_the_site_name is not named in camelCase.
Open

    public function get_the_site_name() {
        /**
         * Filter the site name
         *
         * @param string The site name.
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method the_application_tooltip is not named in camelCase.
Open

    public function the_application_tooltip() {
        /**
         * Filters the application tooltip
         *
         * @param string The application tooltip.
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method the_icon_links is not named in camelCase.
Open

    public function the_icon_links() {
?>
    <!-- ======================== BEGIN SITE ICONS ======================== -->
    <link rel="apple-touch-icon" sizes="57x57" href="<?php TT::the_site_icon_url( 'apple-touch-icon-57x57.png' ); ?>">
    <link rel="apple-touch-icon" sizes="60x60" href="<?php TT::the_site_icon_url( 'apple-touch-icon-60x60.png' ); ?>">
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method get_the_site_icon_url is not named in camelCase.
Open

    public function get_the_site_icon_url( $icon_name ) {
        if ( ! in_array( $icon_name , $this->_icons, true ) ) {
            throw new \UnexpectedValueException( $icon_name . ' is not a known Icon' );
        }
        $query_string = '';
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method the_site_icon_url is not named in camelCase.
Open

    public function the_site_icon_url( $icon_name ) {
        echo esc_url( TT::get_the_site_icon_url( $icon_name ) );
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method the_theme_color is not named in camelCase.
Open

    public function the_theme_color() {
        echo esc_attr( apply_filters( 'mu_site_icons_theme_color', '#ffffff' ) );
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method the_site_name is not named in camelCase.
Open

    public function the_site_name() {
        echo esc_attr( TT::get_the_site_name() );
    }
Severity: Minor
Found in includes/mi11er-utility/class-site-icons.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status