app/models/person.rb
Class Person
has 26 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Person < ActiveRecord::Base
has_one :subscription
has_one :location, dependent: :destroy
has_one :district, through: :location
has_one :representative, through: :district
Method merge_duplicates!
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.merge_duplicates!(records, compare_on:)
records.each do |record|
next if record.nil?
records.each do |other|
next if other.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"