Sign upLogin

MetaPhase-Consulting/State-TalentMAP-API

View on GitHub
Star

Showing 885 of 885 total issues

Function filter_queryset has a Cognitive Complexity of 17 (exceeds 7 allowed). Consider refactoring.
Open

    def filter_queryset(self, request, queryset, view):
        ordering = self.get_ordering(request, queryset, view)
        insensitive_ordering = getattr(view, 'ordering_case_insensitive_fields', ())

        for k in insensitive_ordering:
Severity: Minor
Found in talentmap_api/common/filters.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class AvailableFavoriteTandem(StaticRepresentationModel):

    cp_id = models.CharField(max_length=255, null=False)
    user = models.ForeignKey('user_profile.UserProfile', null=False, on_delete=models.DO_NOTHING, help_text="The user to which this tandem favorite belongs")
    archived = models.BooleanField(default=False)
Severity: Major
Found in talentmap_api/available_tandem/models.py and 1 other location - About 1 hr to fix
talentmap_api/available_positions/models.py on lines 6..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

class AvailablePositionFavorite(StaticRepresentationModel):

    cp_id = models.CharField(max_length=255, null=False)
    user = models.ForeignKey('user_profile.UserProfile', null=False, on_delete=models.DO_NOTHING, help_text="The user to which this favorite belongs")
    archived = models.BooleanField(default=False)
Severity: Major
Found in talentmap_api/available_positions/models.py and 1 other location - About 1 hr to fix
talentmap_api/available_tandem/models.py on lines 5..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function get_queryset has a Cognitive Complexity of 14 (exceeds 7 allowed). Consider refactoring.
Open

    def get_queryset(self):
        # Oracle and Django don't play nice with JSON. This makes filtering by an array of tags difficult.
        # We comma separate the tags provided in the ?tags query parameter (ex: ?tags=a,b,c).
        tags = list(self.request.GET.get('tags', '').split(','))
        # filter out an empty strings
Severity: Minor
Found in talentmap_api/messaging/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convert_to_fsbid_ql has a Cognitive Complexity of 14 (exceeds 7 allowed). Consider refactoring.
Open

def convert_to_fsbid_ql(filters):
    formattedFilters = []

    for fil in filters:
        if pydash.get(fil, 'col') and pydash.get(fil, 'val'):
Severity: Minor
Found in talentmap_api/fsbid/services/common.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_available_bidders_csv has a Cognitive Complexity of 14 (exceeds 7 allowed). Consider refactoring.
Open

def get_available_bidders_csv(request):
    '''
    Returns csv format of Available Bidders list
    '''
    data = client_services.get_available_bidders(request.META['HTTP_JWT'], True, request.query_params, f"{request.scheme}://{request.get_host()}")
Severity: Minor
Found in talentmap_api/cdo/services/available_bidders.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_ap_and_pv_csv has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def get_ap_and_pv_csv(data, filename, ap=False, tandem=False):
    response = HttpResponse(content_type='text/csv')
    response['Content-Disposition'] = f"attachment; filename={filename}_{datetime.now().strftime('%Y_%m_%d_%H%M%S')}.csv"

    writer = csv.writer(response, csv.excel)
Severity: Minor
Found in talentmap_api/fsbid/services/common.py - About 1 hr to fix

    Function get_bids_csv has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def get_bids_csv(data, filename, jwt_token):
    response = HttpResponse(content_type='text/csv')
    response['Content-Disposition'] = f"attachment; filename={filename}_{datetime.now().strftime('%Y_%m_%d_%H%M%S')}.csv"

    writer = csv.writer(response, csv.excel)
    Severity: Minor
    Found in talentmap_api/fsbid/services/common.py - About 1 hr to fix

      Function convert_agenda_employees_query has a Cognitive Complexity of 13 (exceeds 7 allowed). Consider refactoring.
      Open

      def convert_agenda_employees_query(query):
    '''
    Convert TalentMAP filters into FSBid filters
    '''
      Severity: Minor
      Found in talentmap_api/fsbid/services/agenda_employees.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function perform_create has a Cognitive Complexity of 13 (exceeds 7 allowed). Consider refactoring.
      Open

          def perform_create(self, serializer):
        if isinstance(self.request.data, list):
            data = self.request.data
            # Empty array
            if len(data) == 0:
      Severity: Minor
      Found in talentmap_api/available_positions/views/available_position.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fsbid_single_agenda_item_to_talentmap_single_agenda_item has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      def fsbid_single_agenda_item_to_talentmap_single_agenda_item(data, ref_skills={}):
    agendaStatusAbbrev = {
        "Approved": "APR",
        "Deferred - Proposed Position": "XXX",
        "Disapproved": "DIS",
      Severity: Minor
      Found in talentmap_api/fsbid/services/agenda.py - About 1 hr to fix

        Function send_get_csv_request has 10 arguments (exceeds 5 allowed). Consider refactoring.
        Open

        def send_get_csv_request(uri, query, query_mapping_function, jwt_token, mapping_function, base_url, host=None, ad_id=None, limit=None, use_post=False):
        Severity: Major
        Found in talentmap_api/fsbid/services/common.py - About 1 hr to fix

          Function send_get_request has 10 arguments (exceeds 5 allowed). Consider refactoring.
          Open

          def send_get_request(uri, query, query_mapping_function, jwt_token, mapping_function, count_function, base_url, host=None, api_root=API_ROOT, use_post=False):
          Severity: Major
          Found in talentmap_api/fsbid/services/common.py - About 1 hr to fix

            Function service_response has a Cognitive Complexity of 12 (exceeds 7 allowed). Consider refactoring.
            Open

            def service_response(data, objStr, mapping=None):
    '''
    Returns data with additional logger and error handling depending on type
    '''
    if data is None:
            Severity: Minor
            Found in talentmap_api/common/common_helpers.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function parse_child_overrides has a Cognitive Complexity of 12 (exceeds 7 allowed). Consider refactoring.
            Open

                def parse_child_overrides(cls, override_fields, override_exclude, name, nested, child_kwargs):
        '''
        This method populates a dictionary object with appropriate cascaded child serializers

        Args:
            Severity: Minor
            Found in talentmap_api/common/serializers.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_bids_csv has a Cognitive Complexity of 12 (exceeds 7 allowed). Consider refactoring.
            Open

            def get_bids_csv(data, filename, jwt_token):
    response = HttpResponse(content_type='text/csv')
    response['Content-Disposition'] = f"attachment; filename={filename}_{datetime.now().strftime('%Y_%m_%d_%H%M%S')}.csv"

    writer = csv.writer(response, csv.excel)
            Severity: Minor
            Found in talentmap_api/fsbid/services/common.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_bid_status has a Cognitive Complexity of 12 (exceeds 7 allowed). Consider refactoring.
            Open

            def get_bid_status(statusCode, handshakeCode, assignmentCreateDate, panelMeetingStatus, handshakeAllowed):
    '''
    Map the FSBid status code and handshake code to a TalentMap status
        statusCode - W → Draft
            Severity: Minor
            Found in talentmap_api/fsbid/services/bid.py - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validate_filters_exist has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
            Open

            def validate_filters_exist(filter_list, filter_class):
    for filter in filter_list.keys():
        '''
        The filter class (a subclass of FilterSet) passed into this function has knowledge of all
        implicit and declared filters. Declared filters are those explicity instantiated (typically
            Severity: Minor
            Found in talentmap_api/common/common_helpers.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_fsbid_results has a Cognitive Complexity of 11 (exceeds 7 allowed). Consider refactoring.
            Open

            def get_fsbid_results(uri, jwt_token, mapping_function, email=None, use_cache=False, api_root=API_ROOT):
    url = f"{api_root}/{uri}"
    # TODO - fix SSL issue with use_cache
    # method = session if use_cache else requests
    method = requests
            Severity: Minor
            Found in talentmap_api/fsbid/services/common.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function send_count_request has 8 arguments (exceeds 5 allowed). Consider refactoring.
            Open

            def send_count_request(uri, query, query_mapping_function, jwt_token, host=None, api_root=API_ROOT, use_post=False, is_template=False):
            Severity: Major
            Found in talentmap_api/fsbid/services/common.py - About 50 mins to fix
              Severity
              Category
              Status
              Source
              Language