Sign upLogin

MetaPhase-Consulting/State-TalentMAP-API

View on GitHub
Star
talentmap_api/common/xml_helpers.py

Summary

Maintainability
B
5 hrs
Test Coverage
A
91%

Function create_models_from_csv has a Cognitive Complexity of 27 (exceeds 7 allowed). Consider refactoring.
Open

    def create_models_from_csv(self, csv_filepath):
        '''
        Loads data from an CSV file into a model, using a defined mapping of fields
        to CSV column titles.
Severity: Minor
Found in talentmap_api/common/xml_helpers.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if data and len(data.strip()) > 0:
                            setattr(instance, self.tag_map[key], data)
                    else:
Severity: Major
Found in talentmap_api/common/xml_helpers.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if self.collision_behavior == 'delete':
                            collisions.delete()
                            new_instances.append(instance)
                        elif self.collision_behavior == 'update':
                            # Update our collided instance
    Severity: Major
    Found in talentmap_api/common/xml_helpers.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status