Sign upLogin

MetaSyntactical/google-directions-client

View on GitHub
Star

Showing 8 of 8 total issues

Method getDirections has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getDirections(Route $route)
    {
        $uri = $this->createUri($route);
        $request = $this->httpTransport->newRequest()
            ->withMethod('GET')
Severity: Major
Found in src/Client.php - About 2 hrs to fix

    Method createRoute has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createRoute($arrayOfCommaSeparatedCoordinates)
    {
        $coordinates = [];
        foreach ($arrayOfCommaSeparatedCoordinates as $item)
        {
    Severity: Minor
    Found in src/RouteFactory.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function isValidLongitude($value)
    {
        $errormsg = '';
        if ($value < self::GOOGLE_MIN_LONG)
        {
      Severity: Major
      Found in src/Coordinate.php and 1 other location - About 1 hr to fix
      src/Coordinate.php on lines 96..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 117.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function isValidLatitude($value)
    {
        $errormsg = '';
        if ($value < self::GOOGLE_MIN_LAT)
        {
      Severity: Major
      Found in src/Coordinate.php and 1 other location - About 1 hr to fix
      src/Coordinate.php on lines 130..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 117.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method decodePolylineToArray has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function decodePolylineToArray($encoded)
    {
        $length = strlen($encoded);
        $index = 0;
        $points = array();
      Severity: Minor
      Found in src/Polyline.php - About 1 hr to fix

        Function createRoute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createRoute($arrayOfCommaSeparatedCoordinates)
    {
        $coordinates = [];
        foreach ($arrayOfCommaSeparatedCoordinates as $item)
        {
        Severity: Minor
        Found in src/RouteFactory.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return $route;
        Severity: Major
        Found in src/Client.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $route;
          Severity: Major
          Found in src/Client.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language