Sign upLogin

MetaSyntactical/google-directions-client

View on GitHub
Star

Showing 6 of 8 total issues

Method getDirections has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getDirections(Route $route)
    {
        $uri = $this->createUri($route);
        $request = $this->httpTransport->newRequest()
            ->withMethod('GET')
Severity: Major
Found in src/Client.php - About 2 hrs to fix

    Method createRoute has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createRoute($arrayOfCommaSeparatedCoordinates)
    {
        $coordinates = [];
        foreach ($arrayOfCommaSeparatedCoordinates as $item)
        {
    Severity: Minor
    Found in src/RouteFactory.php - About 1 hr to fix

      Method decodePolylineToArray has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function decodePolylineToArray($encoded)
    {
        $length = strlen($encoded);
        $index = 0;
        $points = array();
      Severity: Minor
      Found in src/Polyline.php - About 1 hr to fix

        Function createRoute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createRoute($arrayOfCommaSeparatedCoordinates)
    {
        $coordinates = [];
        foreach ($arrayOfCommaSeparatedCoordinates as $item)
        {
        Severity: Minor
        Found in src/RouteFactory.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return $route;
        Severity: Major
        Found in src/Client.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $route;
          Severity: Major
          Found in src/Client.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language