Sign upLogin

Mezzle/queuejitsu-cli

View on GitHub
Star

Showing 4 of 5 total issues

Method configure has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function configure(): void
    {
        $this->setDescription('Starts Working');
        $this->setHelp('This command starts worker(s) to process the queue.');
Severity: Minor
Found in src/Command/Work.php - About 1 hr to fix

    Function workInBackground has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function workInBackground(InputInterface $input): void
    {
        $worker_count = $input->getOption('workers');

        for ($i = 0; $i < $worker_count; ++$i) {
    Severity: Minor
    Found in src/Command/Work.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method writePidFile() contains an exit expression.
    Open

                die(sprintf('Could not write PID information to %s', $pidfile));
    Severity: Minor
    Found in src/Command/Work.php by phpmd

    ExitExpression

    Since: 0.2

    An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

    Example

    class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

    Source https://phpmd.org/rules/design.html#exitexpression

    Avoid unused parameters such as '$output'.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    Severity: Minor
    Found in src/Command/Work.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Severity
    Category
    Status
    Source
    Language