Sign upLogin

Microsoft/fast-dna

View on GitHub
Star
packages/web-components/fast-element/src/templating/render.ts

Summary

Maintainability
F
3 days
Test Coverage

File render.ts has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { FASTElementDefinition } from "../components/fast-definitions.js";
import type { FASTElement } from "../components/fast-element.js";
import type { DOMPolicy } from "../dom.js";
import { Constructable, isFunction, isString } from "../interfaces.js";
import { Binding, BindingDirective } from "../binding/binding.js";
Severity: Minor
Found in packages/web-components/fast-element/src/templating/render.ts - About 5 hrs to fix

    Function render has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function render<TSource = any, TItem = any, TParent = any>(
    value?: Expression<TSource, TItem> | Binding<TSource, TItem> | {},
    template?:
        | ContentTemplate
        | string
    Severity: Major
    Found in packages/web-components/fast-element/src/templating/render.ts - About 2 hrs to fix

      Function createElementTemplate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      function createElementTemplate<TSource = any, TParent = any>(
    tagName: string,
    options?: ElementCreateOptions
): ViewTemplate<TSource, TParent> {
    const markup: Array<string> = [];
      Severity: Minor
      Found in packages/web-components/fast-element/src/templating/render.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createElementTemplate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createElementTemplate<TSource = any, TParent = any>(
    tagName: string,
    options?: ElementCreateOptions
): ViewTemplate<TSource, TParent> {
    const markup: Array<string> = [];
      Severity: Minor
      Found in packages/web-components/fast-element/src/templating/render.ts - About 1 hr to fix

        Function create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        function create(options: any): RenderInstruction {
    const name = options.name ?? defaultViewName;
    let template: ContentTemplate;

    if (isElementRenderOptions(options)) {
        Severity: Minor
        Found in packages/web-components/fast-element/src/templating/render.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function render has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        export function render<TSource = any, TItem = any, TParent = any>(
    value?: Expression<TSource, TItem> | Binding<TSource, TItem> | {},
    template?:
        | ContentTemplate
        | string
        Severity: Minor
        Found in packages/web-components/fast-element/src/templating/render.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function create has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function create(options: any): RenderInstruction {
    const name = options.name ?? defaultViewName;
    let template: ContentTemplate;

    if (isElementRenderOptions(options)) {
        Severity: Minor
        Found in packages/web-components/fast-element/src/templating/render.ts - About 1 hr to fix

          Function refreshView has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private refreshView() {
        let view = this.view;
        const template = this.template;

        if (view === null) {
          Severity: Minor
          Found in packages/web-components/fast-element/src/templating/render.ts - About 1 hr to fix

            Function refreshView has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private refreshView() {
        let view = this.view;
        const template = this.template;

        if (view === null) {
            Severity: Minor
            Found in packages/web-components/fast-element/src/templating/render.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                        if (isString(result)) {
                result = instructionToTemplate(
                    getForInstance(dataBinding.evaluate(s, c), result)
                );
            } else if (result instanceof Node) {
            Severity: Major
            Found in packages/web-components/fast-element/src/templating/render.ts - About 45 mins to fix

              HACK found
              Open

                      // HACK
              Severity: Minor
              Found in packages/web-components/fast-element/src/templating/render.ts by fixme

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      template.evaluate = (s: any, c: ExecutionContext) => {
            let result = evaluateTemplate(s, c);

            if (isString(result)) {
                result = instructionToTemplate(
              Severity: Major
              Found in packages/web-components/fast-element/src/templating/render.ts and 1 other location - About 3 hrs to fix
              packages/web-components/fast-element/src/templating/render.ts on lines 668..680

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 104.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          (s: any, c: ExecutionContext) => {
                let result = template(s, c);

                if (isString(result)) {
                    result = instructionToTemplate(
              Severity: Major
              Found in packages/web-components/fast-element/src/templating/render.ts and 1 other location - About 3 hrs to fix
              packages/web-components/fast-element/src/templating/render.ts on lines 698..710

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 104.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status