Sign upLogin

Microsoft/fast-dna

View on GitHub
Star
packages/web-components/fast-foundation/src/data-grid/data-grid.ts

Summary

Maintainability
F
4 days
Test Coverage

File data-grid.ts has 697 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { SyntheticViewTemplate, ViewTemplate } from "@microsoft/fast-element";
import {
    attr,
    FASTElement,
    nullableNumberConverter,
Severity: Major
Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 day to fix

    FASTDataGrid has 35 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class FASTDataGrid extends FASTElement {
    /**
     *  generates a basic column definition by examining sample row data
     */
    public static generateColumns(row: object): ColumnDefinition[] {
    Severity: Minor
    Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 4 hrs to fix

      Function handleMultiRowPointerSelection has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          private handleMultiRowPointerSelection(
        changedRow: FASTDataGridRow,
        changeEventDetail: DataGridSelectionChangeDetail
    ): void {
        let newSelection: number[] = this.selectedRowIndexes.slice();
      Severity: Minor
      Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleKeydown has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public handleKeydown(e: KeyboardEvent): void {
        if (e.defaultPrevented) {
            return;
        }
      Severity: Major
      Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 2 hrs to fix

        Function handleKeydown has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public handleKeydown(e: KeyboardEvent): void {
        if (e.defaultPrevented) {
            return;
        }
        Severity: Minor
        Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function connectedCallback has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public connectedCallback(): void {
        super.connectedCallback();

        if (this.rowItemTemplate === undefined) {
            this.rowItemTemplate = this.defaultRowItemTemplate;
        Severity: Minor
        Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 hr to fix

          Function handleMultiRowPointerSelection has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private handleMultiRowPointerSelection(
        changedRow: FASTDataGridRow,
        changeEventDetail: DataGridSelectionChangeDetail
    ): void {
        let newSelection: number[] = this.selectedRowIndexes.slice();
          Severity: Minor
          Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 hr to fix

            Function toggleGeneratedHeader has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                private toggleGeneratedHeader(): void {
        if (this.generatedHeader !== null) {
            this.removeChild(this.generatedHeader);
            this.generatedHeader = null;
        }
            Severity: Minor
            Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function selectAllRows has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private selectAllRows(): void {
        if (
            this.selectionMode !== DataGridSelectionMode.multiRow ||
            this.rowElements.length === 0
        ) {
            Severity: Minor
            Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 hr to fix

              Function handleRowSelectedChange has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public handleRowSelectedChange(e: CustomEvent): void {
        if (e.defaultPrevented || this.selectionMode === DataGridSelectionMode.none) {
            return;
        }
              Severity: Minor
              Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 hr to fix

                Function toggleGeneratedHeader has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private toggleGeneratedHeader(): void {
        if (this.generatedHeader !== null) {
            this.removeChild(this.generatedHeader);
            this.generatedHeader = null;
        }
                Severity: Minor
                Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 1 hr to fix

                  Function handleRowSelectedChange has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public handleRowSelectedChange(e: CustomEvent): void {
        if (e.defaultPrevented || this.selectionMode === DataGridSelectionMode.none) {
            return;
        }
                  Severity: Minor
                  Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function noTabbingChanged has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected noTabbingChanged(): void {
        if (this.$fastController.isConnected) {
            if (this.noTabbing) {
                this.setAttribute("tabIndex", "-1");
            } else {
                  Severity: Minor
                  Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function selectAllRows has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private selectAllRows(): void {
        if (
            this.selectionMode !== DataGridSelectionMode.multiRow ||
            this.rowElements.length === 0
        ) {
                  Severity: Minor
                  Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (
            this.selectionMode === DataGridSelectionMode.singleRow ||
            this.selectionMode === DataGridSelectionMode.multiRow
        ) {
            this.addEventListener("rowselectionchange", this.handleRowSelectedChange);
                  Severity: Minor
                  Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts and 1 other location - About 50 mins to fix
                  packages/web-components/fast-foundation/src/data-grid/data-grid.ts on lines 541..546

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 51.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if (
            this.selectionMode === DataGridSelectionMode.singleRow ||
            this.selectionMode === DataGridSelectionMode.multiRow
        ) {
            this.removeEventListener("rowselectionchange", this.handleRowSelectedChange);
                  Severity: Minor
                  Found in packages/web-components/fast-foundation/src/data-grid/data-grid.ts and 1 other location - About 50 mins to fix
                  packages/web-components/fast-foundation/src/data-grid/data-grid.ts on lines 496..501

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 51.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status