Sign upLogin

Microsoft/fast-dna

View on GitHub
Star
packages/web-components/fast-foundation/src/picker/picker.ts

Summary

Maintainability
F
5 days
Test Coverage

File picker.ts has 624 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { HTMLView, ViewTemplate } from "@microsoft/fast-element";
import {
    attr,
    html,
    nullableNumberConverter,
Severity: Major
Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 1 day to fix

    FASTPicker has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class FASTPicker extends FormAssociatedPicker {
    /**
     * Currently selected items. Comma delineated string ie. "apples,oranges".
     *
     * @remarks
    Severity: Minor
    Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 4 hrs to fix

      Function handleKeyDown has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

          public handleKeyDown(e: KeyboardEvent): boolean {
        if (e.defaultPrevented) {
            return false;
        }
        const activeElement = getRootActiveElement(this);
      Severity: Minor
      Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handleKeyDown has 93 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public handleKeyDown(e: KeyboardEvent): boolean {
        if (e.defaultPrevented) {
            return false;
        }
        const activeElement = getRootActiveElement(this);
      Severity: Major
      Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 3 hrs to fix

        Function incrementFocusedItem has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private incrementFocusedItem(increment: number) {
        if (this.selectedItems.length === 0) {
            this.inputElement.focus();
            return;
        }
        Severity: Minor
        Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 1 hr to fix

          Function incrementFocusedItem has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              private incrementFocusedItem(increment: number) {
        if (this.selectedItems.length === 0) {
            this.inputElement.focus();
            return;
        }
          Severity: Minor
          Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private initialize(): void {
        this.updateListItemTemplate();
        this.updateOptionTemplate();

        if (this.behaviorOrchestrator === null) {
          Severity: Minor
          Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 1 hr to fix

            Function connectedCallback has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public connectedCallback(): void {
        super.connectedCallback();

        if (!this.listElement) {
            this.listElement = document.createElement(
            Severity: Minor
            Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 1 hr to fix

              Function setFocusedOption has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private setFocusedOption(optionIndex: number): void {
        if (
            !this.flyoutOpen ||
            optionIndex === -1 ||
            this.showNoOptions ||
              Severity: Minor
              Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 1 hr to fix

                Function handleOptionInvoke has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    public handleOptionInvoke(e: Event): boolean {
        if (e.defaultPrevented) {
            return false;
        }
                Severity: Minor
                Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this function.
                Open

                                        return false;
                Severity: Major
                Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return true;
                  Severity: Major
                  Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return false;
                    Severity: Major
                    Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                          return false;
                      Severity: Major
                      Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return true;
                        Severity: Major
                        Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                              return true;
                          Severity: Major
                          Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                                return true;
                            Severity: Major
                            Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                              return false;
                              Severity: Major
                              Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                return true;
                                Severity: Major
                                Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return true;
                                  Severity: Major
                                  Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                                        return false;
                                    Severity: Major
                                    Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 30 mins to fix

                                      Function checkMaxItems has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          private checkMaxItems(): void {
        if (this.inputElement === undefined) {
            return;
        }
        if (
                                      Severity: Minor
                                      Found in packages/web-components/fast-foundation/src/picker/picker.ts - About 25 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      TODO found
                                      Open

                                                  // TODO: what should "home" and "end" keys do, exactly?
                                      Severity: Minor
                                      Found in packages/web-components/fast-foundation/src/picker/picker.ts by fixme

                                      TODO found
                                      Open

                                                  // TODO: limit this
                                      Severity: Minor
                                      Found in packages/web-components/fast-foundation/src/picker/picker.ts by fixme

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  this.behaviorOrchestrator.addBehaviorFactory(
                new RepeatDirective(
                    oneWay(x => x.selectedItems),
                    oneWay(x => x.activeListItemTemplate),
                    { positioning: true }
                                      Severity: Major
                                      Found in packages/web-components/fast-foundation/src/picker/picker.ts and 1 other location - About 1 hr to fix
                                      packages/web-components/fast-foundation/src/picker/picker.ts on lines 532..539

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 56.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  this.behaviorOrchestrator.addBehaviorFactory(
                new RepeatDirective(
                    oneWay(x => x.filteredOptionsList),
                    oneWay(x => x.activeMenuOptionTemplate),
                    { positioning: true }
                                      Severity: Major
                                      Found in packages/web-components/fast-foundation/src/picker/picker.ts and 1 other location - About 1 hr to fix
                                      packages/web-components/fast-foundation/src/picker/picker.ts on lines 523..530

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 56.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          private showNoOptionsChanged(): void {
        if (this.$fastController.isConnected) {
            Updates.enqueue(() => {
                this.setFocusedOption(0);
            });
                                      Severity: Major
                                      Found in packages/web-components/fast-foundation/src/picker/picker.ts and 1 other location - About 1 hr to fix
                                      packages/web-components/fast-foundation/src/picker/picker.ts on lines 200..206

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 56.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                          protected showLoadingChanged(): void {
        if (this.$fastController.isConnected) {
            Updates.enqueue(() => {
                this.setFocusedOption(0);
            });
                                      Severity: Major
                                      Found in packages/web-components/fast-foundation/src/picker/picker.ts and 1 other location - About 1 hr to fix
                                      packages/web-components/fast-foundation/src/picker/picker.ts on lines 388..394

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 56.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status