Sign upLogin

Microsoft/fast-dna

View on GitHub
Star
packages/web-components/fast-router/src/commands.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function fromDefinition has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static fromDefinition(
        owner: RouterConfiguration,
        definition:
            | ElementRouteDefinition
            | TemplateRouteDefinition
Severity: Major
Found in packages/web-components/fast-router/src/commands.ts - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                if (def) {
                                factory = factoryFromElementName(def.name);
                            } else {
                                throw new Error(
                                    "Invalid value for element in route config."
    Severity: Major
    Found in packages/web-components/fast-router/src/commands.ts - About 45 mins to fix

      Function fromDefinition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static fromDefinition(
        owner: RouterConfiguration,
        definition:
            | ElementRouteDefinition
            | TemplateRouteDefinition
      Severity: Minor
      Found in packages/web-components/fast-router/src/commands.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status