Sign upLogin

MikeNGarrett/Play-Later

View on GitHub
Star

Showing 129 of 129 total issues

Function play_later has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        play_later: function () {
            var working = false;
            $('.play-later').click(function(event) {
                event.preventDefault();
                if( working ) {
Severity: Minor
Found in js/site.js - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    if( isset( $album['artists'] ) && !empty( $album['artists'] ) && !is_serialized( $album['artists'] ) ) {
                    foreach ($album['artists'] as $artist) {
                        $buf[] = '<a class="artist" href="'.$artist->uri.'">'.$artist->name.'</a>';
                    }
                    echo implode(', ', $buf);
    Severity: Minor
    Found in home.php and 1 other location - About 55 mins to fix
    all.php on lines 421..428

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    if( isset( $album['artists'] ) && !empty( $album['artists'] ) && !is_serialized( $album['artists'] ) ) {
                    foreach ($album['artists'] as $artist) {
                        $buf[] = '<a class="artist" href="'.$artist->uri.'">'.$artist->name.'</a>';
                    }
                    echo implode(', ', $buf);
    Severity: Minor
    Found in all.php and 1 other location - About 55 mins to fix
    home.php on lines 447..454

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    The parameter $class_name is not named in camelCase.
    Open

    function __autoload( $class_name ) {
    $class = str_replace( '\\', '/', $class_name );
    if (file_exists(dirname(__FILE__).'/'.$class . '.php')) {
        require_once dirname(__FILE__).'/'.$class . '.php';
        return true;
    Severity: Minor
    Found in spotify-config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    Avoid variables with short names like $s. Configured minimum length is 3.
    Open

    function xe($s) {
    Severity: Minor
    Found in home.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The property $callback_url is not named in camelCase.
    Open

    class Spotify
{
    public $callback_url;
    public $session;
    public $api;
    Severity: Minor
    Found in spotify-config.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The parameter $spotify_client_id is not named in camelCase.
    Open

        public function __construct( $spotify_client_id = '', $spotify_client_secret = '', $spotify_redirect_uri = '', $callback_url = '')
    {
        // Spotify credentials
        $this->callback_url = $callback_url;
    Severity: Minor
    Found in spotify-config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

        static $e = array('&#38;', '&#34;', '&#60;', '&#62;');
    Severity: Minor
    Found in home.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $e. Configured minimum length is 3.
    Open

        static $e = array('&#38;', '&#34;', '&#60;', '&#62;');
    Severity: Minor
    Found in all.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The parameter $spotify_client_secret is not named in camelCase.
    Open

        public function __construct( $spotify_client_id = '', $spotify_client_secret = '', $spotify_redirect_uri = '', $callback_url = '')
    {
        // Spotify credentials
        $this->callback_url = $callback_url;
    Severity: Minor
    Found in spotify-config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    Avoid variables with short names like $s. Configured minimum length is 3.
    Open

    function xe($s) {
    Severity: Minor
    Found in all.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The parameter $callback_url is not named in camelCase.
    Open

        public function __construct( $spotify_client_id = '', $spotify_client_secret = '', $spotify_redirect_uri = '', $callback_url = '')
    {
        // Spotify credentials
        $this->callback_url = $callback_url;
    Severity: Minor
    Found in spotify-config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    Avoid variables with short names like $me. Configured minimum length is 3.
    Open

    function get_playlist( $me, $api, $offset = 0 ) {
    Severity: Minor
    Found in all.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $u. Configured minimum length is 3.
    Open

        static $u = array('&', '"', '<', '>');
    Severity: Minor
    Found in all.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $me. Configured minimum length is 3.
    Open

    function get_playlist( $me, $api, $offset = 0 ) {
    Severity: Minor
    Found in home.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $v. Configured minimum length is 3.
    Open

    function spotifyCountriesFilter($v) {
    Severity: Minor
    Found in cron/cron.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    The parameter $spotify_redirect_uri is not named in camelCase.
    Open

        public function __construct( $spotify_client_id = '', $spotify_client_secret = '', $spotify_redirect_uri = '', $callback_url = '')
    {
        // Spotify credentials
        $this->callback_url = $callback_url;
    Severity: Minor
    Found in spotify-config.php by phpmd

    CamelCaseParameterName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name parameters.

    Example

    class ClassName {
    public function doSomething($user_name) {
    }
}

    Source

    Avoid variables with short names like $u. Configured minimum length is 3.
    Open

        static $u = array('&', '"', '<', '>');
    Severity: Minor
    Found in home.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid deeply nested control flow statements.
    Open

                    if( !is_array( $genres ) ) {
                    $genres = array();
                }
    Severity: Major
    Found in cron/last-fm-update.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if( !is_array( $last_tags ) ) {
                    $last_tags = array();
                }
      Severity: Major
      Found in cron/last-fm-update.php - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language