Sign upLogin

MikkelHJuul/ld

View on GitHub
Star
impl/delete.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method ldService.DeleteRange has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (l ldService) DeleteRange(keyRange *pb.KeyRange, server pb.Ld_DeleteRangeServer) error {
    matcher, err := NewMatcher(keyRange.Pattern)
    if err != nil {
        log.Debugf("Could not compile matcher from patter, %v: %v", keyRange.Pattern, err)
        return err
Severity: Minor
Found in impl/delete.go - About 1 hr to fix

    Method ldService.Delete has 5 return statements (exceeds 4 allowed).
    Open

    func (l ldService) Delete(_ context.Context, key *pb.Key) (*pb.KeyValue, error) {
    var value []byte
    err := l.DB.Update(func(txn *badger.Txn) (err error) {
        value, err = readSingleFromKey(txn, key)
        if err != nil {
    Severity: Major
    Found in impl/delete.go - About 35 mins to fix

      Method ldService.DeleteRange has 5 return statements (exceeds 4 allowed).
      Open

      func (l ldService) DeleteRange(keyRange *pb.KeyRange, server pb.Ld_DeleteRangeServer) error {
    matcher, err := NewMatcher(keyRange.Pattern)
    if err != nil {
        log.Debugf("Could not compile matcher from patter, %v: %v", keyRange.Pattern, err)
        return err
      Severity: Major
      Found in impl/delete.go - About 35 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if err = l.DB.View(func(txn *badger.Txn) error {
        opts := badger.DefaultIteratorOptions
        opts.PrefetchValues = false
        it := txn.NewIterator(opts)
        defer it.Close()
        Severity: Major
        Found in impl/delete.go and 1 other location - About 2 hrs to fix
        impl/get.go on lines 76..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 203.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status