MiniDigger/Hangar

View on GitHub
apiV2/app/db/impl/query/APIV2Queries.scala

Summary

Maintainability
D
2 days
Test Coverage

File APIV2Queries.scala has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package db.impl.query

import java.sql.Timestamp
import java.time.LocalDateTime

Severity: Minor
Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 4 hrs to fix

    Function projectSelectFrag has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      ): Fragment = {
        val userActionsTaken = currentUserId.fold(fr"FALSE, FALSE,") { id =>
          fr"""|EXISTS(SELECT * FROM project_stars s WHERE s.project_id = p.id AND s.user_id = $id)    AS user_stared,
               |EXISTS(SELECT * FROM project_watchers s WHERE s.project_id = p.id AND s.user_id = $id) AS user_watching,""".stripMargin
        }
    Severity: Major
    Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 2 hrs to fix

      Function versionSelectFrag has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        ): Fragment = {
          val base =
            sql"""|SELECT pv.created_at,
                  |       pv.version_string,
                  |       pv.dependencies,
      Severity: Minor
      Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 1 hr to fix

        Method projectQuery has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              pluginId: Option[String],
              category: List[Category],
              tags: List[String],
              query: Option[String],
              owner: Option[String],
        Severity: Major
        Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 1 hr to fix

          Function actionFrag has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            ): Fragment = {
              val base =
                sql"""|SELECT p.plugin_id,
                      |       p.name,
                      |       p.owner_name,
          Severity: Minor
          Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 1 hr to fix

            Method projectSelectFrag has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  pluginId: Option[String],
                  category: List[Category],
                  tags: List[String],
                  query: Option[String],
                  owner: Option[String],
            Severity: Major
            Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 50 mins to fix

              Method actionQuery has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    table: Fragment,
                    user: String,
                    canSeeHidden: Boolean,
                    currentUserId: Option[DbRef[User]],
                    order: ProjectSortingStrategy,
              Severity: Major
              Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 50 mins to fix

                Method projectCountQuery has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      pluginId: Option[String],
                      category: List[Category],
                      tags: List[String],
                      query: Option[String],
                      owner: Option[String],
                Severity: Major
                Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 50 mins to fix

                  Method watchingQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        user: String,
                        canSeeHidden: Boolean,
                        currentUserId: Option[DbRef[User]],
                        order: ProjectSortingStrategy,
                        limit: Long,
                  Severity: Minor
                  Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 45 mins to fix

                    Method starredQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          user: String,
                          canSeeHidden: Boolean,
                          currentUserId: Option[DbRef[User]],
                          order: ProjectSortingStrategy,
                          limit: Long,
                    Severity: Minor
                    Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 45 mins to fix

                      Method versionQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                            pluginId: String,
                            versionName: Option[String],
                            tags: List[String],
                            limit: Long,
                            offset: Long
                      Severity: Minor
                      Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 35 mins to fix

                        Method createApiKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                              name: String,
                              ownerId: DbRef[User],
                              tokenIdentifier: String,
                              token: String,
                              perms: Permission
                        Severity: Minor
                        Found in apiV2/app/db/impl/query/APIV2Queries.scala - About 35 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                              val ordering = if (orderWithRelevance && query.nonEmpty) {
                                val relevance = query.fold(fr"1") { q =>
                                  fr"ts_rank(p.search_words, websearch_to_tsquery($q)) DESC"
                                }
                                order match {
                          Severity: Major
                          Found in apiV2/app/db/impl/query/APIV2Queries.scala and 1 other location - About 2 hrs to fix
                          ore/app/db/impl/query/AppQueries.scala on lines 44..56

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 189.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                NonEmptyList
                                  .fromList(tags)
                                  .map { t =>
                                    fragParens(
                                      Fragments.or(
                          Severity: Major
                          Found in apiV2/app/db/impl/query/APIV2Queries.scala and 1 other location - About 1 hr to fix
                          apiV2/app/db/impl/query/APIV2Queries.scala on lines 142..153

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 97.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                NonEmptyList
                                  .fromList(tags)
                                  .map { t =>
                                    fragParens(
                                      Fragments.or(
                          Severity: Major
                          Found in apiV2/app/db/impl/query/APIV2Queries.scala and 1 other location - About 1 hr to fix
                          apiV2/app/db/impl/query/APIV2Queries.scala on lines 246..257

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 97.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            implicit val apiV2TagRead: Read[List[APIV2QueryVersionTag]] =
                              viewTagListRead.map(_.map(t => APIV2QueryVersionTag(t.name, t.data, t.color)))
                          Severity: Minor
                          Found in apiV2/app/db/impl/query/APIV2Queries.scala and 1 other location - About 30 mins to fix
                          apiV2/app/db/impl/query/APIV2Queries.scala on lines 30..31

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 60.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            implicit val apiV2TagWrite: Write[List[APIV2QueryVersionTag]] =
                              viewTagListWrite.contramap(_.map(t => ViewTag(t.name, t.data, t.color)))
                          Severity: Minor
                          Found in apiV2/app/db/impl/query/APIV2Queries.scala and 1 other location - About 30 mins to fix
                          apiV2/app/db/impl/query/APIV2Queries.scala on lines 28..29

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 60.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status