Sign upLogin

MiniDigger/Hangar

View on GitHub
Star

Showing 518 of 518 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def showAuthors(sort: Option[String], page: Option[Int]): Action[AnyContent] = OreAction.asyncF { implicit request =>
    val ordering = sort.getOrElse(UserOrdering.Projects)
    val p        = page.getOrElse(1)

    service.runDbCon(UserPagesQueries.getAuthors(p, ordering).to[Vector]).map { u =>
Severity: Major
Found in ore/app/controllers/Users.scala and 1 other location - About 1 hr to fix
ore/app/controllers/Users.scala on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function writeProjects has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  ): IO[Seq[(Model[Project], JsObject)]] = {
    val projectIds = projects.map(_._1.id.value)
    val versionIds = projects.map(_._2.id.value)

    for {
Severity: Minor
Found in ore/app/ore/rest/OreRestfulApiV1.scala - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package ore.models.statistic

import ore.db.impl.DefaultModelCompanion
import ore.db.impl.schema.VersionDownloadsTable
import ore.db.{DbRef, ModelQuery}
    Severity: Major
    Found in models/src/main/scala/ore/models/statistic/VersionDownload.scala and 1 other location - About 1 hr to fix
    models/src/main/scala/ore/models/statistic/ProjectView.scala on lines 1..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    package ore.models.statistic

import ore.db.impl.DefaultModelCompanion
import ore.db.impl.schema.ProjectViewsTable
import ore.db.{DbRef, ModelQuery}
    Severity: Major
    Found in models/src/main/scala/ore/models/statistic/ProjectView.scala and 1 other location - About 1 hr to fix
    models/src/main/scala/ore/models/statistic/VersionDownload.scala on lines 1..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function toString has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    diff_match_patch.patch_obj.prototype.toString = function() {
  var coords1, coords2;
  if (this.length1 === 0) {
    coords1 = this.start1 + ',0';
  } else if (this.length1 == 1) {
    Severity: Minor
    Found in ore/public/diff-match-patch/javascript/diff_match_patch_uncompressed.js - About 1 hr to fix

      Constructor has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            created_at: LocalDateTime,
      name: String,
      dependencies: List[VersionDependency],
      visibility: Visibility,
      description: Option[String],
      Severity: Major
      Found in apiV2/app/models/protocols/APIV2.scala - About 1 hr to fix

        Function diff_compute_ has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        diff_match_patch.prototype.diff_compute_ = function(text1, text2, checklines,
    deadline) {
  var diffs;

  if (!text1) {
        Severity: Minor
        Found in ore/public/diff-match-patch/javascript/diff_match_patch_uncompressed.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Constructor has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            pluginId: String,
    name: String,
    namespace: ProjectNamespace,
    recommendedVersion: Option[String],
    recommendedVersionTags: Option[List[APIV2QueryVersionTag]],
        Severity: Major
        Found in apiV2/app/models/querymodels/apiV2QueryModels.scala - About 1 hr to fix

          Constructor has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              joinable: Model[Project],
    projectOwner: Model[User],
    publicVersions: Int, // project.versions.count(_.visibility === VisibilityTypes.Public)
    settings: Model[ProjectSettings],
    members: Seq[(Model[ProjectUserRole], Model[User])],
          Severity: Major
          Found in orePlayCommon/app/models/viewhelper/ProjectData.scala - About 1 hr to fix

            Constructor has 10 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                namespace: ProjectNamespace,
    visibility: Visibility,
    views: Long,
    downloads: Long,
    stars: Long,
            Severity: Major
            Found in ore/app/models/querymodels/ProjectListEntry.scala - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              package ore.models.api

import ore.db.impl.DefaultModelCompanion
import ore.db.impl.schema.ProjectApiKeyTable
import ore.db.{DbRef, ModelQuery}
              Severity: Major
              Found in models/src/main/scala/ore/models/api/ProjectApiKey.scala and 1 other location - About 1 hr to fix
              models/src/main/scala/ore/models/project/ProjectSettings.scala on lines 1..37

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              package ore.models.project

import ore.db.impl.DefaultModelCompanion
import ore.db.impl.schema.ProjectSettingsTable
import ore.db.{DbRef, ModelQuery}
              Severity: Major
              Found in models/src/main/scala/ore/models/project/ProjectSettings.scala and 1 other location - About 1 hr to fix
              models/src/main/scala/ore/models/api/ProjectApiKey.scala on lines 1..20

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 105.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function diff_cleanupSemanticScore_ has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function diff_cleanupSemanticScore_(one, two) {
    if (!one || !two) {
      // Edges are the best.
      return 6;
    }
              Severity: Minor
              Found in ore/public/diff-match-patch/javascript/diff_match_patch_uncompressed.js - About 1 hr to fix

                Function applyPlacement has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  Tooltip.prototype.applyPlacement = function (offset, placement) {
    var $tip   = this.tip()
    var width  = $tip[0].offsetWidth
    var height = $tip[0].offsetHeight
                Severity: Minor
                Found in ore/public/bootstrap/js/bootstrap.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def visibilityChangesByDate[F[_], V[_, _]: QueryView, VCTable <: VisibilityChangeColumns[Change], Change <: VisibilityChange](
        view: V[VCTable, Model[Change]]
    )(implicit hide: Hideable.Aux[F, M, Change, VCTable]): V[VCTable, Model[Change]] =
      hide.visibilityChangesByDate(m)(view)
                  Severity: Major
                  Found in models/src/main/scala/ore/db/impl/common/Hideable.scala and 1 other location - About 1 hr to fix
                  models/src/main/scala/ore/db/impl/common/Hideable.scala on lines 75..77

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def visibilityChanges[F[_], V[_, _]: QueryView, VCTable <: VisibilityChangeColumns[Change], Change <: VisibilityChange](
        view: V[VCTable, Model[Change]]
    )(implicit hide: Hideable.Aux[F, M, Change, VCTable]): V[VCTable, Model[Change]] = hide.visibilityChanges(m)(view)
                  Severity: Major
                  Found in models/src/main/scala/ore/db/impl/common/Hideable.scala and 1 other location - About 1 hr to fix
                  models/src/main/scala/ore/db/impl/common/Hideable.scala on lines 79..82

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 103.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function show has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    Tab.prototype.show = function () {
    var $this    = this.element
    var $ul      = $this.closest('ul:not(.dropdown-menu)')
    var selector = $this.data('target')
                  Severity: Minor
                  Found in ore/public/bootstrap/js/bootstrap.js - About 1 hr to fix

                    Function initColorPicker has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function initColorPicker() {
    var modal = getModal();
    // Initialize popover to stay opened when hovered over
    modal.find(".color-picker").popover({
        html: true,
                    Severity: Minor
                    Found in ore/public/javascripts/channelManage.js - About 1 hr to fix

                      Function updateProjectTopic has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def updateProjectTopic(project: Model[Project]): F[Boolean] = {
    require(project.topicId.isDefined, "undefined topic id")
    require(project.postId.isDefined, "undefined post id")

    val topicId   = project.topicId
                      Severity: Minor
                      Found in ore/app/discourse/OreDiscourseApiEnabled.scala - About 1 hr to fix

                        Function provideOreDiscourseApi has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          ): OreDiscourseApi[IO] = {
    val forums = config.forums
    if (forums.api.enabled) {
      val api = forums.api
                        Severity: Minor
                        Found in ore/app/Module.scala - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language