Sign upLogin

MiniDigger/Hangar

View on GitHub
Star
ore/app/controllers/project/Projects.scala

Summary

Maintainability
C
1 day
Test Coverage

File Projects.scala has 499 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package controllers.project

import java.nio.file.{Files, Path}
import java.security.MessageDigest
import java.util.Base64
Severity: Minor
Found in ore/app/controllers/project/Projects.scala - About 1 day to fix

    Function setVisible has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def setVisible(author: String, slug: String, visibility: Int): Action[AnyContent] = {
    AuthedProjectAction(author, slug, requireUnlock = true)
      .andThen(ProjectPermissionAction(Permission.Reviewer))
      .asyncF { implicit request =>
        val newVisibility = Visibility.withValue(visibility)
    Severity: Minor
    Found in ore/app/controllers/project/Projects.scala - About 1 hr to fix

      Method showUserGrid has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            author: String,
      slug: String,
      page: Option[Int],
      title: String,
      query: Model[Project] => Query[UserTable, Model[User], Seq],
      Severity: Minor
      Found in ore/app/controllers/project/Projects.scala - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              user
        .projectRoles(ModelView.now(ProjectUserRole))
        .get(id)
        .semiflatMap { role =>
          import MembershipDossier._
        Severity: Major
        Found in ore/app/controllers/project/Projects.scala and 1 other location - About 2 hrs to fix
        ore/app/controllers/Organizations.scala on lines 98..109

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 155.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status