Sign upLogin

MiniDigger/Hangar

View on GitHub
Star
ore/app/controllers/project/Versions.scala

Summary

Maintainability
F
3 days
Test Coverage

File Versions.scala has 708 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package controllers.project

import java.nio.file.Files._
import java.nio.file.{Files, StandardCopyOption}
import java.time.Instant
Severity: Major
Found in ore/app/controllers/project/Versions.scala - About 1 day to fix

    Function showDownloadConfirm has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      ): Action[AnyContent] = {
    ProjectAction(author, slug).asyncEitherT { implicit request =>
      val dlType              = downloadType.flatMap(DownloadType.withValueOpt).getOrElse(DownloadType.UploadedFile)
      implicit val lang: Lang = request.lang
      val project             = request.project
    Severity: Major
    Found in ore/app/controllers/project/Versions.scala - About 2 hrs to fix

      Function publish has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def publish(author: String, slug: String, versionString: String): Action[AnyContent] = {
    UserLock(ShowProject(author, slug)).asyncF { implicit request =>
      // First get the pending Version
      this.factory.getPendingVersion(author, slug, versionString) match {
        case None =>
      Severity: Major
      Found in ore/app/controllers/project/Versions.scala - About 2 hrs to fix

        Function sendJar has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          ): IO[Result] = {
    if (project.visibility == Visibility.SoftDelete) {
      IO.pure(NotFound)
    } else {
      checkConfirmation(version, token).flatMap { passed =>
        Severity: Minor
        Found in ore/app/controllers/project/Versions.scala - About 1 hr to fix

          Function confirmDownload0 has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            ): OptionT[IO, (Model[UnsafeDownload], Option[play.api.mvc.Session])] = {
    val addr = InetString(StatTracker.remoteAddress)
    val dlType = downloadType
      .flatMap(DownloadType.withValueOpt)
      .getOrElse(DownloadType.UploadedFile)
          Severity: Minor
          Found in ore/app/controllers/project/Versions.scala - About 1 hr to fix

            Function approve has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def approve(author: String, slug: String, versionString: String, partial: Boolean): Action[AnyContent] = {
    AuthedProjectAction(author, slug, requireUnlock = true)
      .andThen(ProjectPermissionAction(Permission.Reviewer))
      .asyncEitherT { implicit request =>
        val newState = if (partial) ReviewState.PartiallyReviewed else ReviewState.Reviewed
            Severity: Minor
            Found in ore/app/controllers/project/Versions.scala - About 1 hr to fix

              Method showDownloadConfirm has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    author: String,
      slug: String,
      target: String,
      downloadType: Option[Int],
      api: Option[Boolean],
              Severity: Minor
              Found in ore/app/controllers/project/Versions.scala - About 45 mins to fix

                Method confirmDownload has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      author: String,
      slug: String,
      target: String,
      downloadType: Option[Int],
      token: Option[String],
                Severity: Minor
                Found in ore/app/controllers/project/Versions.scala - About 45 mins to fix

                  Function checkConfirmation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    private def checkConfirmation(version: Model[Version], token: Option[String])(
      implicit req: ProjectRequest[_]
  ): IO[Boolean] = {
    if (version.reviewState == ReviewState.Reviewed)
      IO.pure(true)
                  Severity: Minor
                  Found in ore/app/controllers/project/Versions.scala - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def downloadRecommended(author: String, slug: String, token: Option[String]): Action[AnyContent] = {
    ProjectAction(author, slug).asyncEitherT { implicit request =>
      request.project
        .recommendedVersion(ModelView.now(Version))
        .sequence
                  Severity: Major
                  Found in ore/app/controllers/project/Versions.scala and 1 other location - About 1 hr to fix
                  ore/app/controllers/project/Versions.scala on lines 885..894

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 99.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def downloadRecommendedJar(author: String, slug: String, token: Option[String]): Action[AnyContent] = {
    ProjectAction(author, slug).asyncEitherT { implicit request =>
      request.project
        .recommendedVersion(ModelView.now(Version))
        .sequence
                  Severity: Major
                  Found in ore/app/controllers/project/Versions.scala and 1 other location - About 1 hr to fix
                  ore/app/controllers/project/Versions.scala on lines 791..800

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 99.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status