MiniDigger/Hangar

View on GitHub
ore/app/db/impl/query/AppQueries.scala

Summary

Maintainability
C
1 day
Test Coverage

Function getHomeProjects has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  ): Query0[ProjectListEntry] = {
    //TODO: Let the query handle tag search in the future
    val platformFrag = platformNames.map(_.toLowerCase).toNel.map(Fragments.in(fr"lower(p.tag_name)", _))
    val categoryFrag = categories.toNel.map(Fragments.in(fr"p.category", _))
    val visibilityFrag =
Severity: Major
Found in ore/app/db/impl/query/AppQueries.scala - About 2 hrs to fix

    Function getQueue has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      val getQueue: Query0[UnsortedQueueEntry] = {
        val reviewStateId = ReviewState.Unreviewed.value
        sql"""|SELECT sq.project_author,
              |       sq.project_slug,
              |       sq.project_name,
    Severity: Minor
    Found in ore/app/db/impl/query/AppQueries.scala - About 1 hr to fix

      Method getHomeProjects has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            currentUserId: Option[DbRef[User]],
            canSeeHidden: Boolean,
            platformNames: List[String],
            categories: List[Category],
            query: Option[String],
      Severity: Major
      Found in ore/app/db/impl/query/AppQueries.scala - About 1 hr to fix

        Method getLog has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              oPage: Option[Int],
              userFilter: Option[DbRef[User]],
              projectFilter: Option[DbRef[Project]],
              versionFilter: Option[DbRef[Version]],
              pageFilter: Option[DbRef[Page]],
        Severity: Major
        Found in ore/app/db/impl/query/AppQueries.scala - About 50 mins to fix

          TODO found
          Open

              //TODO: Let the query handle tag search in the future

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              val ordering = if (orderWithRelevance && query.nonEmpty) {
                val relevance = query.fold(fr"1") { q =>
                  fr"ts_rank(p.search_words, websearch_to_tsquery($q)) DESC"
                }
                order match {
          Severity: Major
          Found in ore/app/db/impl/query/AppQueries.scala and 1 other location - About 2 hrs to fix
          apiV2/app/db/impl/query/APIV2Queries.scala on lines 175..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 189.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status